Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2722973002: Revert of Make generate_gradle.py work with preview SDKs. (Closed)

Created:
3 years, 9 months ago by agrieve
Modified:
3 years, 9 months ago
Reviewers:
nyquist, estevenson
CC:
chromium-reviews, mikecase+watch_chromium.org, nyquist+watch_chromium.org, jbudorick+watch_chromium.org, wnwen+watch_chromium.org, agrieve+watch_chromium.org, awdf, Peter Wen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make generate_gradle.py work with preview SDKs. (patchset #1 id:1 of https://codereview.chromium.org/2724513003/ ) Reason for revert: Breaks when CWD != output_dir Original issue's description: > Make generate_gradle.py work with preview SDKs. > > This just tweaks the values of buildToolsVersion and compileSdkVersion, > which were not being set in a way compatible with preview SDKs. > > BUG=620034 > > Review-Url: https://codereview.chromium.org/2724513003 > Cr-Commit-Position: refs/heads/master@{#453737} > Committed: https://chromium.googlesource.com/chromium/src/+/1a04e1cf3d4912300d625a57318bc6f2ba53ba79 TBR=estevenson@chromium.org,nyquist@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=620034 Review-Url: https://codereview.chromium.org/2722973002 Cr-Commit-Position: refs/heads/master@{#453788} Committed: https://chromium.googlesource.com/chromium/src/+/aa0d524b8614ab29c29b960ea87c7df647b99a03

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M build/android/gradle/android.jinja View 1 chunk +1 line, -1 line 0 comments Download
M build/android/gradle/generate_gradle.py View 3 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
agrieve
Created Revert of Make generate_gradle.py work with preview SDKs.
3 years, 9 months ago (2017-03-01 01:24:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722973002/1
3 years, 9 months ago (2017-03-01 01:25:02 UTC) #3
nyquist
lgtm
3 years, 9 months ago (2017-03-01 01:25:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/aa0d524b8614ab29c29b960ea87c7df647b99a03
3 years, 9 months ago (2017-03-01 01:27:22 UTC) #7
agrieve
3 years, 9 months ago (2017-03-01 02:16:09 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2727523002/ by agrieve@chromium.org.

The reason for reverting is: will fix..

Powered by Google App Engine
This is Rietveld 408576698