Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2724513003: Make generate_gradle.py work with preview SDKs. (Closed)

Created:
3 years, 9 months ago by agrieve
Modified:
3 years, 9 months ago
Reviewers:
nyquist, estevenson
CC:
chromium-reviews, mikecase+watch_chromium.org, nyquist+watch_chromium.org, jbudorick+watch_chromium.org, wnwen+watch_chromium.org, agrieve+watch_chromium.org, awdf, Peter Wen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make generate_gradle.py work with preview SDKs. This just tweaks the values of buildToolsVersion and compileSdkVersion, which were not being set in a way compatible with preview SDKs. BUG=620034 Review-Url: https://codereview.chromium.org/2724513003 Cr-Commit-Position: refs/heads/master@{#453737} Committed: https://chromium.googlesource.com/chromium/src/+/1a04e1cf3d4912300d625a57318bc6f2ba53ba79

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M build/android/gradle/android.jinja View 1 chunk +1 line, -1 line 0 comments Download
M build/android/gradle/generate_gradle.py View 3 chunks +9 lines, -7 lines 2 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
estevenson
lgtm lgtm
3 years, 9 months ago (2017-02-28 19:40:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724513003/1
3 years, 9 months ago (2017-02-28 20:27:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1a04e1cf3d4912300d625a57318bc6f2ba53ba79
3 years, 9 months ago (2017-02-28 23:22:54 UTC) #8
nyquist
https://codereview.chromium.org/2724513003/diff/1/build/android/gradle/generate_gradle.py File build/android/gradle/generate_gradle.py (right): https://codereview.chromium.org/2724513003/diff/1/build/android/gradle/generate_gradle.py#newcode518 build/android/gradle/generate_gradle.py:518: os.path.join(build_vars['android_sdk_build_tools'], 'source.properties')) In my local checkout, os.getcwd() ends up ...
3 years, 9 months ago (2017-03-01 01:22:12 UTC) #10
agrieve
https://codereview.chromium.org/2724513003/diff/1/build/android/gradle/generate_gradle.py File build/android/gradle/generate_gradle.py (right): https://codereview.chromium.org/2724513003/diff/1/build/android/gradle/generate_gradle.py#newcode518 build/android/gradle/generate_gradle.py:518: os.path.join(build_vars['android_sdk_build_tools'], 'source.properties')) On 2017/03/01 01:22:12, nyquist wrote: > In ...
3 years, 9 months ago (2017-03-01 01:24:16 UTC) #11
agrieve
3 years, 9 months ago (2017-03-01 01:24:38 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2722973002/ by agrieve@chromium.org.

The reason for reverting is: Breaks when CWD != output_dir.

Powered by Google App Engine
This is Rietveld 408576698