Remove ColorBehavior argument to Image::imageForCurrentFrame

Remove ColorBehavior argument to Image::imageForCurrentFrame

This will need to eventually tag the SkImage with an appropriate
SkColorSpace for all sub-classes.

For callers that expect a certain output color space, we should provide
a new entrypoint indicates the expected color space and performs the
required conversion.

R=junov
TBR=esprehn
BUG=667411
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2727133002
Cr-Commit-Position: refs/heads/master@{#455299}
Committed: https://chromium.googlesource.com/chromium/src/+/4121a1f03af37216d8f219cfdc4899e71ee2f4cf

[ccameron, 2017-03-02 03:14:59]

Description was changed from

==========
Remove ColorBehavior argument to Image::imageForCurrentFrame

This will need to eventually tag the SkImage with an appropriate
SkColorSpace for all sub-classes.

For callers that expect a certain output color space, we should provide
a separate API call that indicates the expected color space.

BUG=667411
==========

to

==========
Remove ColorBehavior argument to Image::imageForCurrentFrame

This will need to eventually tag the SkImage with an appropriate
SkColorSpace for all sub-classes.

For callers that expect a certain output color space, we should provide
a separate API call that indicates the expected color space.

BUG=667411
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2017-03-02 03:15:10]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 03:16:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 03:41:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 03:41:12]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[ccameron, 2017-03-02 23:00:20]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 23:01:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 23:25:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 23:25:24]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[ccameron, 2017-03-02 23:33:23]

Description was changed from

==========
Remove ColorBehavior argument to Image::imageForCurrentFrame

This will need to eventually tag the SkImage with an appropriate
SkColorSpace for all sub-classes.

For callers that expect a certain output color space, we should provide
a separate API call that indicates the expected color space.

BUG=667411
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove ColorBehavior argument to Image::imageForCurrentFrame

This will need to eventually tag the SkImage with an appropriate
SkColorSpace for all sub-classes.

For callers that expect a certain output color space, we should provide
a new entrypoint indicates the expected color space and performs the
required conversion.

BUG=667411
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2017-03-02 23:33:23]

ccameron@chromium.org changed reviewers:
+ junov@chromium.org

[ccameron, 2017-03-02 23:34:05]

ptal

[Justin Novosad, 2017-03-03 19:34:58]

lgtm

https://codereview.chromium.org/2727133002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/ImageData.cpp (right):

https://codereview.chromium.org/2727133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/ImageData.cpp:37: #include
"platform/graphics/ColorBehavior.h"
Is this because it used to be indirectly included?

[ccameron, 2017-03-03 20:13:21]

Thanks!

https://codereview.chromium.org/2727133002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/ImageData.cpp (right):

https://codereview.chromium.org/2727133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/ImageData.cpp:37: #include
"platform/graphics/ColorBehavior.h"
On 2017/03/03 19:34:57, Justin Novosad wrote:
> Is this because it used to be indirectly included?

Yes, exactly.

[ccameron, 2017-03-07 00:20:58]

Description was changed from

==========
Remove ColorBehavior argument to Image::imageForCurrentFrame

This will need to eventually tag the SkImage with an appropriate
SkColorSpace for all sub-classes.

For callers that expect a certain output color space, we should provide
a new entrypoint indicates the expected color space and performs the
required conversion.

BUG=667411
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove ColorBehavior argument to Image::imageForCurrentFrame

This will need to eventually tag the SkImage with an appropriate
SkColorSpace for all sub-classes.

For callers that expect a certain output color space, we should provide
a new entrypoint indicates the expected color space and performs the
required conversion.

BUG=667411
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2017-03-07 00:21:08]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[ccameron, 2017-03-07 00:22:05]

Description was changed from

==========
Remove ColorBehavior argument to Image::imageForCurrentFrame

This will need to eventually tag the SkImage with an appropriate
SkColorSpace for all sub-classes.

For callers that expect a certain output color space, we should provide
a new entrypoint indicates the expected color space and performs the
required conversion.

BUG=667411
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove ColorBehavior argument to Image::imageForCurrentFrame

This will need to eventually tag the SkImage with an appropriate
SkColorSpace for all sub-classes.

For callers that expect a certain output color space, we should provide
a new entrypoint indicates the expected color space and performs the
required conversion.

R=junov
TBR=esprehn
BUG=667411
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2017-03-07 00:22:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-03-07 01:48:29]

The CQ bit was unchecked by ccameron@chromium.org

[ccameron, 2017-03-07 01:49:00]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-03-07 01:49:01]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2727133002/#ps60001
(title: "Remove ColorBehavior argument to Image::imageForCurrentFrame")

[commit-bot: I haz the power, 2017-03-07 01:50:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 04:10:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 04:10:49]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ccameron, 2017-03-07 05:48:55]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-03-07 05:49:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 08:25:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 08:25:03]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ccameron, 2017-03-07 08:46:38]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-03-07 08:46:39]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2727133002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-07 08:47:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 10:31:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 10:31:15]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ccameron, 2017-03-07 18:49:06]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-03-07 18:50:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 23:57:23]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488912546474080,
"parent_rev": "0235e672998b36b2bf5beb45ce1e24ae3ac729af", "commit_rev":
"4121a1f03af37216d8f219cfdc4899e71ee2f4cf"}

[commit-bot: I haz the power, 2017-03-07 23:58:08]

Description was changed from

==========
Remove ColorBehavior argument to Image::imageForCurrentFrame

This will need to eventually tag the SkImage with an appropriate
SkColorSpace for all sub-classes.

For callers that expect a certain output color space, we should provide
a new entrypoint indicates the expected color space and performs the
required conversion.

R=junov
TBR=esprehn
BUG=667411
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove ColorBehavior argument to Image::imageForCurrentFrame

This will need to eventually tag the SkImage with an appropriate
SkColorSpace for all sub-classes.

For callers that expect a certain output color space, we should provide
a new entrypoint indicates the expected color space and performs the
required conversion.

R=junov
TBR=esprehn
BUG=667411
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2727133002
Cr-Commit-Position: refs/heads/master@{#455299}
Committed:
https://chromium.googlesource.com/chromium/src/+/4121a1f03af37216d8f219cfdc48...
==========

[commit-bot: I haz the power, 2017-03-07 23:58:10]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/4121a1f03af37216d8f219cfdc48...