third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp - Issue 2727133002: Remove ColorBehavior argument to Image::imageForCurrentFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp

Issue 2727133002: Remove ColorBehavior argument to Image::imageForCurrentFrame (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h ('k') | third_party/WebKit/Source/platform/graphics/BitmapImage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp b/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp

index 903f3e0098caecacec6d8502175caa509bdb5ba7..3ab8fd713663034a541b2fce0a74d65c1d4cb3ae 100644

--- a/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp

+++ b/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp

@@ -89,13 +89,10 @@ void AcceleratedStaticBitmapImage::copyToTexture(

destGL->DeleteTextures(1, &sourceTextureId);

}

-sk_sp<SkImage> AcceleratedStaticBitmapImage::imageForCurrentFrame(

- const ColorBehavior& colorBehavior) {

+sk_sp<SkImage> AcceleratedStaticBitmapImage::imageForCurrentFrame() {

// TODO(xlai): Refactor so that sync tokens are only used when

// |m_textureHolder| is MailboxTextureHolder.

// https://crbug.com/693229

- // TODO(ccameron): This function should not ignore |colorBehavior|.

- // https://crbug.com/672306

checkThread();

if (!isValid())

return nullptr;