third_party/WebKit/Source/platform/exported/WebImage.cpp - Issue 2727133002: Remove ColorBehavior argument to Image::imageForCurrentFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/WebImage.cpp

Issue 2727133002: Remove ColorBehavior argument to Image::imageForCurrentFrame (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/exported/WebImage.cpp

diff --git a/third_party/WebKit/Source/platform/exported/WebImage.cpp b/third_party/WebKit/Source/platform/exported/WebImage.cpp

index 5c2fe6ef7894b50e335c259bf35f619d0dcfb530..29a3a4f189fdff8bc5a52d76424d90ce4312fc43 100644

--- a/third_party/WebKit/Source/platform/exported/WebImage.cpp

+++ b/third_party/WebKit/Source/platform/exported/WebImage.cpp

@@ -132,10 +132,7 @@ WebImage::WebImage(PassRefPtr<Image> image) {

if (!image)

return;

- // TODO(ccameron): WebImage needs to be consistent about color spaces.

- // https://crbug.com/672315

- if (sk_sp<SkImage> skImage =

- image->imageForCurrentFrame(ColorBehavior::transformToGlobalTarget()))

+ if (sk_sp<SkImage> skImage = image->imageForCurrentFrame())

skImage->asLegacyBitmap(&m_bitmap, SkImage::kRO_LegacyBitmapMode);

}