Fix ASAN ODR violation in ppapi/proxy in component mode

Fix ASAN ODR violation in ppapi/proxy in component mode

See https://groups.google.com/a/chromium.org/d/topic/chromium-dev/12dRlYvL9nI/discussion.

Confirmed with

gn gen out/asan --args="is_asan=true enable_nacl=false is_debug=false use_goma=true is_component_build=true"

BUG=581766
Review-Url: https://codereview.chromium.org/2727093003
Cr-Commit-Position: refs/heads/master@{#454533}
Committed: https://chromium.googlesource.com/chromium/src/+/5178c39691068004da38a0dcc69ee6b6271445dd

[scottmg, 2017-03-02 05:22:17]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 05:23:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2017-03-02 05:23:19]

Description was changed from

==========
FixASAN ODR violation in ppapi/proxy in component mode

R=palmer@chromium.org
BUG=581766
==========

to

==========
FixASAN ODR violation in ppapi/proxy in component mode

See
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/12dRlYvL9nI/dis....

R=palmer@chromium.org
BUG=581766
==========

[scottmg, 2017-03-02 05:23:41]

Description was changed from

==========
FixASAN ODR violation in ppapi/proxy in component mode

See
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/12dRlYvL9nI/dis....

R=palmer@chromium.org
BUG=581766
==========

to

==========
FixASAN ODR violation in ppapi/proxy in component mode

See
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/12dRlYvL9nI/dis....

Confirmed with

gn gen out/asan --args="is_asan=true enable_nacl=false is_debug=false
use_goma=true is_component_build=true"

R=palmer@chromium.org
BUG=581766
==========

[scottmg, 2017-03-02 05:23:49]

Description was changed from

==========
FixASAN ODR violation in ppapi/proxy in component mode

See
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/12dRlYvL9nI/dis....

Confirmed with

gn gen out/asan --args="is_asan=true enable_nacl=false is_debug=false
use_goma=true is_component_build=true"

R=palmer@chromium.org
BUG=581766
==========

to

==========
Fix ASAN ODR violation in ppapi/proxy in component mode

See
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/12dRlYvL9nI/dis....

Confirmed with

gn gen out/asan --args="is_asan=true enable_nacl=false is_debug=false
use_goma=true is_component_build=true"

R=palmer@chromium.org
BUG=581766
==========

[scottmg, 2017-03-02 05:25:41]

scottmg@chromium.org changed reviewers:
+ raymes@chromium.org
- palmer@chromium.org

[scottmg, 2017-03-02 05:25:50]

Description was changed from

==========
Fix ASAN ODR violation in ppapi/proxy in component mode

See
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/12dRlYvL9nI/dis....

Confirmed with

gn gen out/asan --args="is_asan=true enable_nacl=false is_debug=false
use_goma=true is_component_build=true"

R=palmer@chromium.org
BUG=581766
==========

to

==========
Fix ASAN ODR violation in ppapi/proxy in component mode

See
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/12dRlYvL9nI/dis....

Confirmed with

gn gen out/asan --args="is_asan=true enable_nacl=false is_debug=false
use_goma=true is_component_build=true"

BUG=581766
==========

[raymes, 2017-03-02 05:51:04]

rs lgtm

[scottmg, 2017-03-02 05:52:29]

The CQ bit was unchecked by scottmg@chromium.org

[scottmg, 2017-03-02 05:52:32]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2017-03-02 05:52:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2017-03-02 05:59:27]

The CQ bit was unchecked by scottmg@chromium.org

[scottmg, 2017-03-02 06:31:56]

Patchset #2 (id:20001) has been deleted

[scottmg, 2017-03-02 06:32:38]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 06:33:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2017-03-02 06:44:38]

Patchset #2 (id:40001) has been deleted

[scottmg, 2017-03-02 06:44:44]

Patchset #2 (id:60001) has been deleted

[scottmg, 2017-03-02 07:10:42]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[scottmg, 2017-03-02 07:10:54]

Patchset #3 (id:100001) has been deleted

[scottmg, 2017-03-02 07:10:58]

Patchset #2 (id:80001) has been deleted

[commit-bot: I haz the power, 2017-03-02 07:11:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2017-03-02 07:12:02]

Patchset #2 (id:120001) has been deleted

[scottmg, 2017-03-02 07:12:18]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 07:12:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2017-03-02 07:14:55]

Making that target a component didn't work on Windows unless I made a whole new
_export.h which seemed a bit silly for some integral constants. So instead I
just put them directly into the .h and this way I get to delete the .cc and the
export related goop.

Please take another quick look.

[commit-bot: I haz the power, 2017-03-02 09:13:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 09:13:03]

Dry run: This issue passed the CQ dry run.

[scottmg, 2017-03-03 06:48:23]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2017-03-03 06:48:24]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/2727093003/#ps140001
(title: "simplify, no export")

[commit-bot: I haz the power, 2017-03-03 06:48:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 06:53:46]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1488523703775820,
"parent_rev": "9bb7606ad29dac25a5a1d281de8daf4b73765c3a", "commit_rev":
"5178c39691068004da38a0dcc69ee6b6271445dd"}

[commit-bot: I haz the power, 2017-03-03 06:54:37]

Description was changed from

==========
Fix ASAN ODR violation in ppapi/proxy in component mode

See
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/12dRlYvL9nI/dis....

Confirmed with

gn gen out/asan --args="is_asan=true enable_nacl=false is_debug=false
use_goma=true is_component_build=true"

BUG=581766
==========

to

==========
Fix ASAN ODR violation in ppapi/proxy in component mode

See
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/12dRlYvL9nI/dis....

Confirmed with

gn gen out/asan --args="is_asan=true enable_nacl=false is_debug=false
use_goma=true is_component_build=true"

BUG=581766

Review-Url: https://codereview.chromium.org/2727093003
Cr-Commit-Position: refs/heads/master@{#454533}
Committed:
https://chromium.googlesource.com/chromium/src/+/5178c39691068004da38a0dcc69e...
==========

[commit-bot: I haz the power, 2017-03-03 06:54:38]

Committed patchset #2 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/5178c39691068004da38a0dcc69e...