ppapi/proxy/tcp_socket_resource_base.cc - Issue 2727093003: Fix ASAN ODR violation in ppapi/proxy in component mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/tcp_socket_resource_base.cc

Issue 2727093003: Fix ASAN ODR violation in ppapi/proxy in component mode (Closed)

Patch Set: simplify, no export Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/proxy/tcp_socket_resource_base.cc

diff --git a/ppapi/proxy/tcp_socket_resource_base.cc b/ppapi/proxy/tcp_socket_resource_base.cc

index 2ec45c25f4f9d67aeb8f5e6f9bf5467e695738ee..356a43e22db0414d39b2cd14b10955bb0517b276 100644

--- a/ppapi/proxy/tcp_socket_resource_base.cc

+++ b/ppapi/proxy/tcp_socket_resource_base.cc

@@ -207,7 +207,8 @@ int32_t TCPSocketResourceBase::ReadImpl(

return PP_ERROR_INPROGRESS;

read_buffer_ = buffer;

bytes_to_read_ =

- std::min(bytes_to_read, TCPSocketResourceConstants::kMaxReadSize);

+ std::min(bytes_to_read,

+ static_cast<int32_t>(TCPSocketResourceConstants::kMaxReadSize));

read_callback_ = callback;

Call<PpapiPluginMsg_TCPSocket_ReadReply>(

« no previous file with comments | « ppapi/proxy/BUILD.gn ('k') | ppapi/proxy/tcp_socket_resource_constants.h » ('j') | no next file with comments »