Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: ppapi/proxy/udp_socket_resource_constants.h

Issue 2727093003: Fix ASAN ODR violation in ppapi/proxy in component mode (Closed)
Patch Set: simplify, no export Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ppapi/proxy/udp_socket_filter.cc ('k') | ppapi/proxy/udp_socket_resource_constants.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdint.h> 5 #include <stdint.h>
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "ppapi/proxy/ppapi_proxy_export.h"
9 8
10 namespace ppapi { 9 namespace ppapi {
11 namespace proxy { 10 namespace proxy {
12 11
13 class PPAPI_PROXY_EXPORT UDPSocketResourceConstants { 12 class UDPSocketResourceConstants {
14 public: 13 public:
15 // The maximum number of bytes that each 14 // The maximum number of bytes that each
16 // PpapiPluginMsg_PPBUDPSocket_PushRecvResult message is allowed to carry. 15 // PpapiPluginMsg_PPBUDPSocket_PushRecvResult message is allowed to carry.
17 static const int32_t kMaxReadSize; 16 enum { kMaxReadSize = 128 * 1024 };
18 // The maximum number of bytes that each PpapiHostMsg_PPBUDPSocket_SendTo 17 // The maximum number of bytes that each PpapiHostMsg_PPBUDPSocket_SendTo
19 // message is allowed to carry. 18 // message is allowed to carry.
20 static const int32_t kMaxWriteSize; 19 enum { kMaxWriteSize = 128 * 1024 };
21 20
22 // The maximum number that we allow for setting 21 // The maximum number that we allow for setting
23 // PP_UDPSOCKET_OPTION_SEND_BUFFER_SIZE. This number is only for input 22 // PP_UDPSOCKET_OPTION_SEND_BUFFER_SIZE. This number is only for input
24 // argument sanity check, it doesn't mean the browser guarantees to support 23 // argument sanity check, it doesn't mean the browser guarantees to support
25 // such a buffer size. 24 // such a buffer size.
26 static const int32_t kMaxSendBufferSize; 25 enum { kMaxSendBufferSize = 1024 * kMaxWriteSize };
27 // The maximum number that we allow for setting 26 // The maximum number that we allow for setting
28 // PP_UDPSOCKET_OPTION_RECV_BUFFER_SIZE. This number is only for input 27 // PP_UDPSOCKET_OPTION_RECV_BUFFER_SIZE. This number is only for input
29 // argument sanity check, it doesn't mean the browser guarantees to support 28 // argument sanity check, it doesn't mean the browser guarantees to support
30 // such a buffer size. 29 // such a buffer size.
31 static const int32_t kMaxReceiveBufferSize; 30 enum { kMaxReceiveBufferSize = 1024 * kMaxReadSize };
32 31
33 // The maximum number of received packets that we allow instances of this 32 // The maximum number of received packets that we allow instances of this
34 // class to buffer. 33 // class to buffer.
35 static const size_t kPluginReceiveBufferSlots; 34 enum { kPluginReceiveBufferSlots = 32u };
36 // The maximum number of buffers that we allow instances of this class to be 35 // The maximum number of buffers that we allow instances of this class to be
37 // sending before we block the plugin. 36 // sending before we block the plugin.
38 static const size_t kPluginSendBufferSlots; 37 enum { kPluginSendBufferSlots = 8u };
39 38
40 private: 39 private:
41 DISALLOW_COPY_AND_ASSIGN(UDPSocketResourceConstants); 40 DISALLOW_COPY_AND_ASSIGN(UDPSocketResourceConstants);
42 }; 41 };
43 42
44 } // namespace proxy 43 } // namespace proxy
45 } // namespace ppapi 44 } // namespace ppapi
OLDNEW
« no previous file with comments | « ppapi/proxy/udp_socket_filter.cc ('k') | ppapi/proxy/udp_socket_resource_constants.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698