Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: ppapi/proxy/udp_socket_resource_constants.h

Issue 2727093003: Fix ASAN ODR violation in ppapi/proxy in component mode (Closed)
Patch Set: simplify, no export Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/udp_socket_filter.cc ('k') | ppapi/proxy/udp_socket_resource_constants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/udp_socket_resource_constants.h
diff --git a/ppapi/proxy/udp_socket_resource_constants.h b/ppapi/proxy/udp_socket_resource_constants.h
index e9dd953c2df1d761298419468458864abd5f0b41..e3f8f22ff15b1a96f46a4d090b01f5bee390c7e2 100644
--- a/ppapi/proxy/udp_socket_resource_constants.h
+++ b/ppapi/proxy/udp_socket_resource_constants.h
@@ -5,37 +5,36 @@
#include <stdint.h>
#include "base/macros.h"
-#include "ppapi/proxy/ppapi_proxy_export.h"
namespace ppapi {
namespace proxy {
-class PPAPI_PROXY_EXPORT UDPSocketResourceConstants {
+class UDPSocketResourceConstants {
public:
// The maximum number of bytes that each
// PpapiPluginMsg_PPBUDPSocket_PushRecvResult message is allowed to carry.
- static const int32_t kMaxReadSize;
+ enum { kMaxReadSize = 128 * 1024 };
// The maximum number of bytes that each PpapiHostMsg_PPBUDPSocket_SendTo
// message is allowed to carry.
- static const int32_t kMaxWriteSize;
+ enum { kMaxWriteSize = 128 * 1024 };
// The maximum number that we allow for setting
// PP_UDPSOCKET_OPTION_SEND_BUFFER_SIZE. This number is only for input
// argument sanity check, it doesn't mean the browser guarantees to support
// such a buffer size.
- static const int32_t kMaxSendBufferSize;
+ enum { kMaxSendBufferSize = 1024 * kMaxWriteSize };
// The maximum number that we allow for setting
// PP_UDPSOCKET_OPTION_RECV_BUFFER_SIZE. This number is only for input
// argument sanity check, it doesn't mean the browser guarantees to support
// such a buffer size.
- static const int32_t kMaxReceiveBufferSize;
+ enum { kMaxReceiveBufferSize = 1024 * kMaxReadSize };
// The maximum number of received packets that we allow instances of this
// class to buffer.
- static const size_t kPluginReceiveBufferSlots;
+ enum { kPluginReceiveBufferSlots = 32u };
// The maximum number of buffers that we allow instances of this class to be
// sending before we block the plugin.
- static const size_t kPluginSendBufferSlots;
+ enum { kPluginSendBufferSlots = 8u };
private:
DISALLOW_COPY_AND_ASSIGN(UDPSocketResourceConstants);
« no previous file with comments | « ppapi/proxy/udp_socket_filter.cc ('k') | ppapi/proxy/udp_socket_resource_constants.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698