Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2726573002: Rebaseline crypto/subtle/*/cloneKey.html. (Closed)

Created:
3 years, 9 months ago by jbroman
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rebaseline crypto/subtle/*/cloneKey.html. This V8-side change: https://codereview.chromium.org/2709023003 added an explicit one-byte "host object" prefix to Blink's objects. BUG=686159 Review-Url: https://codereview.chromium.org/2726573002 Cr-Original-Commit-Position: refs/heads/master@{#453822} Committed: https://chromium.googlesource.com/chromium/src/+/3e96e467116cd7e573911400b9b1d383a46e775f Review-Url: https://codereview.chromium.org/2726573002 Cr-Commit-Position: refs/heads/master@{#454804} Committed: https://chromium.googlesource.com/chromium/src/+/4a1788dd92171c1f9384a3ebd6b751e1aa239926

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -271 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/aes-cbc/cloneKey-expected.txt View 12 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/aes-ctr/cloneKey-expected.txt View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/aes-gcm/cloneKey-expected.txt View 12 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/aes-kw/cloneKey-expected.txt View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/ecdh/cloneKey-expected.txt View 12 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/ecdsa/cloneKey-expected.txt View 18 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/hkdf/cloneKey-expected.txt View 45 chunks +45 lines, -45 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/hmac/cloneKey-expected.txt View 72 chunks +72 lines, -72 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/pbkdf2/cloneKey-expected.txt View 45 chunks +45 lines, -45 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5/cloneKey-expected.txt View 36 chunks +36 lines, -36 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
jbroman
3 years, 9 months ago (2017-02-28 15:28:42 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-02-28 23:41:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726573002/1
3 years, 9 months ago (2017-03-01 03:00:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3e96e467116cd7e573911400b9b1d383a46e775f
3 years, 9 months ago (2017-03-01 03:25:24 UTC) #12
jonross
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2725763004/ by jonross@chromium.org. ...
3 years, 9 months ago (2017-03-02 16:18:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726573002/1
3 years, 9 months ago (2017-03-05 23:49:11 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 00:48:59 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4a1788dd92171c1f9384a3ebd6b7...

Powered by Google App Engine
This is Rietveld 408576698