Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2709023003: ValueSerializer: Add an explicit tag for host objects. (Closed)

Created:
3 years, 10 months ago by jbroman
Modified:
3 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ValueSerializer: Add an explicit tag for host objects. This makes it no longer necessary to ensure that V8 and Blink have non-colliding tags, which makes it easier for them to evolve independently, and also makes the wire format more suitable for other V8 embedders, who would not necessarily be surveyed before V8 introduced a new tag that might collide with theirs. BUG=chromium:686159 Review-Url: https://codereview.chromium.org/2709023003 Cr-Commit-Position: refs/heads/master@{#43466} Committed: https://chromium.googlesource.com/v8/v8/+/6543519977b2012b58a4ffef28b8527db404fbdb

Patch Set 1 #

Patch Set 2 : add a unit test #

Patch Set 3 : correct version number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -7 lines) Patch
M src/value-serializer.cc View 4 chunks +16 lines, -5 lines 0 comments Download
M test/unittests/value-serializer-unittest.cc View 1 2 2 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
jbroman
PTAL
3 years, 10 months ago (2017-02-23 20:32:59 UTC) #10
Jakob Kummerow
lgtm
3 years, 10 months ago (2017-02-24 13:55:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709023003/40001
3 years, 9 months ago (2017-02-28 01:51:07 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 02:16:37 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/6543519977b2012b58a4ffef28b8527db40...

Powered by Google App Engine
This is Rietveld 408576698