Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 2725763004: Revert of Rebaseline crypto/subtle/*/cloneKey.html. (Closed)

Created:
3 years, 9 months ago by jonross
Modified:
3 years, 9 months ago
Reviewers:
haraken, jbroman
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Rebaseline crypto/subtle/*/cloneKey.html. (patchset #1 id:1 of https://codereview.chromium.org/2726573002/ ) Reason for revert: The v8 version which these tests are based on was rolled back: https://codereview.chromium.org/2728453005 So the tests are now failing. Original issue's description: > Rebaseline crypto/subtle/*/cloneKey.html. > > This V8-side change: > https://codereview.chromium.org/2709023003 > added an explicit one-byte "host object" prefix to Blink's objects. > > BUG=686159 > > Review-Url: https://codereview.chromium.org/2726573002 > Cr-Commit-Position: refs/heads/master@{#453822} > Committed: https://chromium.googlesource.com/chromium/src/+/3e96e467116cd7e573911400b9b1d383a46e775f TBR=haraken@chromium.org,jbroman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=686159 Review-Url: https://codereview.chromium.org/2725763004 Cr-Commit-Position: refs/heads/master@{#454296} Committed: https://chromium.googlesource.com/chromium/src/+/bf016e6d001abcfe472090c052c98c8e6165c09b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2841 lines, -2830 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/aes-cbc/cloneKey-expected.txt View 7 chunks +92 lines, -92 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/aes-ctr/cloneKey-expected.txt View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/aes-gcm/cloneKey-expected.txt View 7 chunks +92 lines, -92 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/aes-kw/cloneKey-expected.txt View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/ecdh/cloneKey-expected.txt View 7 chunks +92 lines, -92 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/ecdsa/cloneKey-expected.txt View 10 chunks +146 lines, -146 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/hkdf/cloneKey-expected.txt View 1 chunk +661 lines, -661 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/hmac/cloneKey-expected.txt View 37 chunks +702 lines, -702 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/pbkdf2/cloneKey-expected.txt View 1 chunk +661 lines, -661 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5/cloneKey-expected.txt View 19 chunks +376 lines, -376 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jonross
Created Revert of Rebaseline crypto/subtle/*/cloneKey.html.
3 years, 9 months ago (2017-03-02 16:18:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725763004/1
3 years, 9 months ago (2017-03-02 16:19:13 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 17:41:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bf016e6d001abcfe472090c052c9...

Powered by Google App Engine
This is Rietveld 408576698