Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2728453005: Update the V8 version for Chromium branch 58. (Closed)

Created:
3 years, 9 months ago by Michael Hablich
Modified:
3 years, 9 months ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the V8 version for Chromium branch 58. This is a roll-back to 5.8.283. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. TBR=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2728453005 Cr-Commit-Position: refs/heads/master@{#454241} Committed: https://chromium.googlesource.com/chromium/src/+/a8be5d4dabe8587567639e63831e3fc74ee089c2

Patch Set 1 #

Patch Set 2 : Required merge added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728453005/1
3 years, 9 months ago (2017-03-02 10:49:21 UTC) #2
Michael Achenbach
lgtm
3 years, 9 months ago (2017-03-02 10:58:42 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/220981) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 9 months ago (2017-03-02 11:07:41 UTC) #5
Michael Hablich
On 2017/03/02 at 11:07:41, commit-bot wrote: > Try jobs failed on following builders: > cast_shell_android ...
3 years, 9 months ago (2017-03-02 11:17:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728453005/20001
3 years, 9 months ago (2017-03-02 11:45:24 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 13:01:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a8be5d4dabe8587567639e63831e...

Powered by Google App Engine
This is Rietveld 408576698