Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2725513002: Increment property tree sequence number when updating. (Closed)

Created:
3 years, 9 months ago by wkorman
Modified:
3 years, 9 months ago
Reviewers:
pdr., ajuma
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increment property tree sequence number when updating. BUG=692842 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2725513002 Cr-Commit-Position: refs/heads/master@{#453746} Committed: https://chromium.googlesource.com/chromium/src/+/0c0f9ef081109ce6fdeee588d356238272d7b9f8

Patch Set 1 #

Patch Set 2 : Add tests and move increment. #

Total comments: 2

Patch Set 3 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -14 lines) Patch
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 1 2 4 chunks +15 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp View 1 1 chunk +49 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp View 4 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
wkorman
I recall seeing someone (pdr@?) comment on a code review, re: overflow concerns for a ...
3 years, 9 months ago (2017-02-28 01:42:26 UTC) #5
ajuma
lgtm
3 years, 9 months ago (2017-02-28 15:45:36 UTC) #6
pdr.
LGTM here as well. Looks great! https://codereview.chromium.org/2725513002/diff/20001/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp File third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp (right): https://codereview.chromium.org/2725513002/diff/20001/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp#newcode65 third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp:65: static int sPropertyTreeSequenceNumber ...
3 years, 9 months ago (2017-02-28 17:44:59 UTC) #7
wkorman
https://codereview.chromium.org/2725513002/diff/20001/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp File third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp (right): https://codereview.chromium.org/2725513002/diff/20001/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp#newcode65 third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp:65: static int sPropertyTreeSequenceNumber = 1; On 2017/02/28 17:44:58, pdr. ...
3 years, 9 months ago (2017-02-28 20:58:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725513002/40001
3 years, 9 months ago (2017-02-28 20:59:25 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 23:45:36 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0c0f9ef081109ce6fdeee588d356...

Powered by Google App Engine
This is Rietveld 408576698