Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp

Issue 2725513002: Increment property tree sequence number when updating. (Closed)
Patch Set: Add comment. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
index 4ba29654bc53cdce0e0480a25d1f1e48177930f6..4d8e2bb5a8cea6a96de438efec67770db247303d 100644
--- a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
+++ b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
@@ -1764,4 +1764,53 @@ TEST_F(PaintArtifactCompositorTestWithPropertyTrees, CompositedLuminanceMask) {
EXPECT_EQ(cc::FilterOperation::REFERENCE, maskingGroup->filters.at(0).type());
}
+TEST_F(PaintArtifactCompositorTestWithPropertyTrees,
+ UpdateProducesNewSequenceNumber) {
+ // A 90 degree clockwise rotation about (100, 100).
+ RefPtr<TransformPaintPropertyNode> transform =
+ TransformPaintPropertyNode::create(
+ TransformPaintPropertyNode::root(), TransformationMatrix().rotate(90),
+ FloatPoint3D(100, 100, 0), false, 0, CompositingReason3DTransform);
+
+ RefPtr<ClipPaintPropertyNode> clip = ClipPaintPropertyNode::create(
+ ClipPaintPropertyNode::root(), TransformPaintPropertyNode::root(),
+ FloatRoundedRect(100, 100, 300, 200));
+
+ RefPtr<EffectPaintPropertyNode> effect =
+ createOpacityOnlyEffect(EffectPaintPropertyNode::root(), 0.5);
+
+ TestPaintArtifact artifact;
+ artifact.chunk(transform, clip, effect)
+ .rectDrawing(FloatRect(0, 0, 100, 100), Color::white);
+ artifact
+ .chunk(TransformPaintPropertyNode::root(), ClipPaintPropertyNode::root(),
+ EffectPaintPropertyNode::root())
+ .rectDrawing(FloatRect(0, 0, 100, 100), Color::gray);
+ update(artifact.build());
+
+ // Two content layers for the differentiated rect drawings and three dummy
+ // layers for each of the transform, clip and effect nodes.
+ EXPECT_EQ(5u, rootLayer()->children().size());
+ EXPECT_EQ(1, propertyTrees().sequence_number);
+ for (auto layer : rootLayer()->children()) {
+ EXPECT_EQ(1, layer->property_tree_sequence_number());
+ }
+
+ update(artifact.build());
+
+ EXPECT_EQ(5u, rootLayer()->children().size());
+ EXPECT_EQ(2, propertyTrees().sequence_number);
+ for (auto layer : rootLayer()->children()) {
+ EXPECT_EQ(2, layer->property_tree_sequence_number());
+ }
+
+ update(artifact.build());
+
+ EXPECT_EQ(5u, rootLayer()->children().size());
+ EXPECT_EQ(3, propertyTrees().sequence_number);
+ for (auto layer : rootLayer()->children()) {
+ EXPECT_EQ(3, layer->property_tree_sequence_number());
+ }
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698