Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.h

Issue 2725513002: Increment property tree sequence number when updating. (Closed)
Patch Set: Add comment. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef PropertyTreeManager_h 5 #ifndef PropertyTreeManager_h
6 #define PropertyTreeManager_h 6 #define PropertyTreeManager_h
7 7
8 #include "wtf/HashMap.h" 8 #include "wtf/HashMap.h"
9 #include "wtf/HashSet.h" 9 #include "wtf/HashSet.h"
10 #include "wtf/Noncopyable.h" 10 #include "wtf/Noncopyable.h"
(...skipping 14 matching lines...) Expand all
25 class EffectPaintPropertyNode; 25 class EffectPaintPropertyNode;
26 class ScrollPaintPropertyNode; 26 class ScrollPaintPropertyNode;
27 class TransformPaintPropertyNode; 27 class TransformPaintPropertyNode;
28 28
29 // Mutates a cc property tree to reflect Blink paint property tree 29 // Mutates a cc property tree to reflect Blink paint property tree
30 // state. Intended for use by PaintArtifactCompositor. 30 // state. Intended for use by PaintArtifactCompositor.
31 class PropertyTreeManager { 31 class PropertyTreeManager {
32 WTF_MAKE_NONCOPYABLE(PropertyTreeManager); 32 WTF_MAKE_NONCOPYABLE(PropertyTreeManager);
33 33
34 public: 34 public:
35 PropertyTreeManager(cc::PropertyTrees&, cc::Layer* rootLayer); 35 PropertyTreeManager(cc::PropertyTrees&,
36 36 cc::Layer* rootLayer,
37 static constexpr int kPropertyTreeSequenceNumber = 1; 37 int sequenceNumber);
38 38
39 void setupRootTransformNode(); 39 void setupRootTransformNode();
40 void setupRootClipNode(); 40 void setupRootClipNode();
41 void setupRootEffectNode(); 41 void setupRootEffectNode();
42 void setupRootScrollNode(); 42 void setupRootScrollNode();
43 43
44 // A brief discourse on cc property tree nodes, identifiers, and current and 44 // A brief discourse on cc property tree nodes, identifiers, and current and
45 // future design evolution envisioned: 45 // future design evolution envisioned:
46 // 46 //
47 // cc property trees identify nodes by their |id|, which implementation-wise 47 // cc property trees identify nodes by their |id|, which implementation-wise
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 HashMap<const ClipPaintPropertyNode*, int> m_clipNodeMap; 111 HashMap<const ClipPaintPropertyNode*, int> m_clipNodeMap;
112 HashMap<const ScrollPaintPropertyNode*, int> m_scrollNodeMap; 112 HashMap<const ScrollPaintPropertyNode*, int> m_scrollNodeMap;
113 113
114 struct BlinkEffectAndCcIdPair { 114 struct BlinkEffectAndCcIdPair {
115 const EffectPaintPropertyNode* effect; 115 const EffectPaintPropertyNode* effect;
116 // The cc property tree effect node id, or 'node index', for the cc effect 116 // The cc property tree effect node id, or 'node index', for the cc effect
117 // node corresponding to the above Blink effect paint property node. 117 // node corresponding to the above Blink effect paint property node.
118 int id; 118 int id;
119 }; 119 };
120 Vector<BlinkEffectAndCcIdPair> m_effectStack; 120 Vector<BlinkEffectAndCcIdPair> m_effectStack;
121 int m_sequenceNumber;
121 122
122 #if DCHECK_IS_ON() 123 #if DCHECK_IS_ON()
123 HashSet<const EffectPaintPropertyNode*> m_effectNodesConverted; 124 HashSet<const EffectPaintPropertyNode*> m_effectNodesConverted;
124 #endif 125 #endif
125 }; 126 };
126 127
127 } // namespace blink 128 } // namespace blink
128 129
129 #endif // PropertyTreeManager_h 130 #endif // PropertyTreeManager_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698