Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp

Issue 2725513002: Increment property tree sequence number when updating. (Closed)
Patch Set: Add comment. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp
index a47117c9f1627f76506f98eadf06d211e67ae38f..754722a3779cd2f0b760d52398b0c0aa129acc0c 100644
--- a/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp
+++ b/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp
@@ -33,8 +33,11 @@ static constexpr int kSecondaryRootNodeId = 1;
} // namespace
PropertyTreeManager::PropertyTreeManager(cc::PropertyTrees& propertyTrees,
- cc::Layer* rootLayer)
- : m_propertyTrees(propertyTrees), m_rootLayer(rootLayer) {
+ cc::Layer* rootLayer,
+ int sequenceNumber)
+ : m_propertyTrees(propertyTrees),
+ m_rootLayer(rootLayer),
+ m_sequenceNumber(sequenceNumber) {
setupRootTransformNode();
setupRootClipNode();
setupRootEffectNode();
@@ -191,7 +194,7 @@ int PropertyTreeManager::ensureCompositorTransformNode(
dummyLayer->SetClipTreeIndex(kSecondaryRootNodeId);
dummyLayer->SetEffectTreeIndex(kSecondaryRootNodeId);
dummyLayer->SetScrollTreeIndex(kRealRootNodeId);
- dummyLayer->set_property_tree_sequence_number(kPropertyTreeSequenceNumber);
+ dummyLayer->set_property_tree_sequence_number(m_sequenceNumber);
CompositorElementId compositorElementId =
transformNode->compositorElementId();
if (compositorElementId) {
@@ -244,7 +247,7 @@ int PropertyTreeManager::ensureCompositorClipNode(
dummyLayer->SetClipTreeIndex(id);
dummyLayer->SetEffectTreeIndex(kSecondaryRootNodeId);
dummyLayer->SetScrollTreeIndex(kRealRootNodeId);
- dummyLayer->set_property_tree_sequence_number(kPropertyTreeSequenceNumber);
+ dummyLayer->set_property_tree_sequence_number(m_sequenceNumber);
auto result = m_clipNodeMap.set(clipNode, id);
DCHECK(result.isNewEntry);
@@ -452,7 +455,7 @@ void PropertyTreeManager::buildEffectNodesRecursively(
}
m_effectStack.push_back(BlinkEffectAndCcIdPair{nextEffect, effectNode.id});
- dummyLayer->set_property_tree_sequence_number(kPropertyTreeSequenceNumber);
+ dummyLayer->set_property_tree_sequence_number(m_sequenceNumber);
dummyLayer->SetTransformTreeIndex(kSecondaryRootNodeId);
dummyLayer->SetClipTreeIndex(outputClipId);
dummyLayer->SetEffectTreeIndex(effectNode.id);
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698