Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2725423002: gn: Make grit() default to requiring qualified #includes. (Closed)

Created:
3 years, 9 months ago by Nico
Modified:
3 years, 9 months ago
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Make grit() default to requiring qualified #includes. Once this has been in the tree for a while, we can remove all the `use_qualified_include = true` lines. BUG=401588 Review-Url: https://codereview.chromium.org/2725423002 Cr-Commit-Position: refs/heads/master@{#454918} Committed: https://chromium.googlesource.com/chromium/src/+/7fa89a1107a81e961053b4a7e9f12fd8de6ca030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M chromecast/app/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/libaddressinput/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/grit/grit_rule.gni View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Nico
brettw: grit_rule.gni slan: chromecast rouslan: libaddressinput
3 years, 9 months ago (2017-03-03 23:16:08 UTC) #3
please use gerrit instead
lgtm
3 years, 9 months ago (2017-03-05 06:37:50 UTC) #8
brettw
lgtm
3 years, 9 months ago (2017-03-06 18:06:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725423002/1
3 years, 9 months ago (2017-03-06 18:21:43 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 19:36:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7fa89a1107a81e961053b4a7e9f1...

Powered by Google App Engine
This is Rietveld 408576698