Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10131)

Unified Diff: chromecast/app/BUILD.gn

Issue 2725423002: gn: Make grit() default to requiring qualified #includes. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/libaddressinput/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/app/BUILD.gn
diff --git a/chromecast/app/BUILD.gn b/chromecast/app/BUILD.gn
index 55c82872acf7249b9aac59cafb5f60295085629a..1cceb9a3f01acd4e9d96e4967ff68d20518a1596 100644
--- a/chromecast/app/BUILD.gn
+++ b/chromecast/app/BUILD.gn
@@ -106,8 +106,12 @@ grit("chromecast_settings") {
source = "//chromecast/app/resources/chromecast_settings.grd"
resource_ids = "//chromecast/app/resources/resource_ids"
- # TODO(thakis): Consider removing this in favor of the default directory.
+ # TODO(thakis): Consider removing output_dir in favor of the default
+ # directory, then it becomes possible to qualify includes of
+ # grit/chromecast_settings.h and DEPS files work better too.
+ # https://crbug.com/697090
output_dir = "$root_gen_dir/chromecast_strings"
+ use_qualified_include = false
outputs = [
"grit/chromecast_settings.h",
« no previous file with comments | « no previous file | third_party/libaddressinput/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698