third_party/libaddressinput/BUILD.gn - Issue 2725423002: gn: Make grit() default to requiring qualified #includes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libaddressinput/BUILD.gn

Issue 2725423002: gn: Make grit() default to requiring qualified #includes. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libaddressinput/BUILD.gn

diff --git a/third_party/libaddressinput/BUILD.gn b/third_party/libaddressinput/BUILD.gn

index cea22aeca067f524eeddb5e0f52f5fe2832afae9..e4e5381cb150297f335bd930291ec7fcb7e4e9be 100644

--- a/third_party/libaddressinput/BUILD.gn

+++ b/third_party/libaddressinput/BUILD.gn

@@ -14,6 +14,10 @@ config("no-newline-eof-warning") {

grit("strings") {

source = "//chrome/app/address_input_strings.grd"

+ # libaddressinput's tests just say `#include "messages.h"`.

+ use_qualified_include = false

outputs = [

"messages.h",

"en_messages.cc",

« no previous file with comments | « chromecast/app/BUILD.gn ('k') | tools/grit/grit_rule.gni » ('j') | no next file with comments »