Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: chromecast/app/BUILD.gn

Issue 2725423002: gn: Make grit() default to requiring qualified #includes. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/libaddressinput/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//testing/test.gni") 5 import("//testing/test.gni")
6 import("//tools/grit/grit_rule.gni") 6 import("//tools/grit/grit_rule.gni")
7 7
8 source_set("app") { 8 source_set("app") {
9 sources = [ 9 sources = [
10 "cast_main_delegate.cc", 10 "cast_main_delegate.cc",
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 outputs = [ 99 outputs = [
100 "grit/shell_resources.h", 100 "grit/shell_resources.h",
101 "shell_resources.pak", 101 "shell_resources.pak",
102 ] 102 ]
103 } 103 }
104 104
105 grit("chromecast_settings") { 105 grit("chromecast_settings") {
106 source = "//chromecast/app/resources/chromecast_settings.grd" 106 source = "//chromecast/app/resources/chromecast_settings.grd"
107 resource_ids = "//chromecast/app/resources/resource_ids" 107 resource_ids = "//chromecast/app/resources/resource_ids"
108 108
109 # TODO(thakis): Consider removing this in favor of the default directory. 109 # TODO(thakis): Consider removing output_dir in favor of the default
110 # directory, then it becomes possible to qualify includes of
111 # grit/chromecast_settings.h and DEPS files work better too.
112 # https://crbug.com/697090
110 output_dir = "$root_gen_dir/chromecast_strings" 113 output_dir = "$root_gen_dir/chromecast_strings"
114 use_qualified_include = false
111 115
112 outputs = [ 116 outputs = [
113 "grit/chromecast_settings.h", 117 "grit/chromecast_settings.h",
114 "chromecast_settings_am.pak", 118 "chromecast_settings_am.pak",
115 "chromecast_settings_ar.pak", 119 "chromecast_settings_ar.pak",
116 "chromecast_settings_bg.pak", 120 "chromecast_settings_bg.pak",
117 "chromecast_settings_bn.pak", 121 "chromecast_settings_bn.pak",
118 "chromecast_settings_ca.pak", 122 "chromecast_settings_ca.pak",
119 "chromecast_settings_cs.pak", 123 "chromecast_settings_cs.pak",
120 "chromecast_settings_da.pak", 124 "chromecast_settings_da.pak",
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 "chromecast_settings_ta.pak", 164 "chromecast_settings_ta.pak",
161 "chromecast_settings_te.pak", 165 "chromecast_settings_te.pak",
162 "chromecast_settings_th.pak", 166 "chromecast_settings_th.pak",
163 "chromecast_settings_tr.pak", 167 "chromecast_settings_tr.pak",
164 "chromecast_settings_uk.pak", 168 "chromecast_settings_uk.pak",
165 "chromecast_settings_vi.pak", 169 "chromecast_settings_vi.pak",
166 "chromecast_settings_zh-CN.pak", 170 "chromecast_settings_zh-CN.pak",
167 "chromecast_settings_zh-TW.pak", 171 "chromecast_settings_zh-TW.pak",
168 ] 172 ]
169 } 173 }
OLDNEW
« no previous file with comments | « no previous file | third_party/libaddressinput/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698