[wasm] Implement simd lowering for F32x4 and I32x4 compare ops

[wasm] Implement simd lowering for F32x4 and I32x4 compare ops

R=bbudge@chromium.org,titzer@chromium.org,gdeepti@chromium.org,bradnelson@chromium.org,mtrofin@chromium.org
BUG=v8:6020
Review-Url: https://codereview.chromium.org/2728823005
Cr-Commit-Position: refs/heads/master@{#43562}
Committed: https://chromium.googlesource.com/v8/v8/+/8b130a8495232a4c1a349256a0e2a3cc4b0ba434

[bbudge, 2017-03-02 18:29:09]

https://codereview.chromium.org/2728823005/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2728823005/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:3422: inputs[0], inputs[1]);
Follow the pattern below where Lt and Le are implemented with Ge and Gt,
switching the order of the inputs. We should probably also remove the redundant
machine operators.

[bbudge, 2017-03-02 23:10:59]

lgtm

https://codereview.chromium.org/2728823005/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2728823005/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:3422: inputs[0], inputs[1]);
On 2017/03/02 18:29:09, bbudge wrote:
> Follow the pattern below where Lt and Le are implemented with Ge and Gt,
> switching the order of the inputs. We should probably also remove the
redundant
> machine operators.

Just add a TODO to make the machine operators minimal (lt and le).

[Mircea Trofin, 2017-03-03 00:20:59]

On 2017/03/02 23:10:59, bbudge wrote:
> lgtm
> 
>
https://codereview.chromium.org/2728823005/diff/1/src/compiler/wasm-compiler.cc
> File src/compiler/wasm-compiler.cc (right):
> 
>
https://codereview.chromium.org/2728823005/diff/1/src/compiler/wasm-compiler....
> src/compiler/wasm-compiler.cc:3422: inputs[0], inputs[1]);
> On 2017/03/02 18:29:09, bbudge wrote:
> > Follow the pattern below where Lt and Le are implemented with Ge and Gt,
> > switching the order of the inputs. We should probably also remove the
> redundant
> > machine operators.
> 
> Just add a TODO to make the machine operators minimal (lt and le).

Lgtm for compiler part

[aseemgarg, 2017-03-03 02:07:24]

The CQ bit was checked by aseemgarg@chromium.org

[aseemgarg, 2017-03-03 02:07:24]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org,
mtrofin@chromium.org
Link to the patchset: https://codereview.chromium.org/2728823005/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-03 02:07:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 02:31:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488506844294170,
"parent_rev": "81ad6b521fc070542fa09964a0f5451759c89680", "commit_rev":
"8b130a8495232a4c1a349256a0e2a3cc4b0ba434"}

[commit-bot: I haz the power, 2017-03-03 02:31:49]

Description was changed from

==========
[wasm] Implement simd lowering for F32x4 and I32x4 compare ops

R=bbudge@chromium.org,titzer@chromium.org,gdeepti@chromium.org,bradnelson@chr...
BUG=v8:6020
==========

to

==========
[wasm] Implement simd lowering for F32x4 and I32x4 compare ops

R=bbudge@chromium.org,titzer@chromium.org,gdeepti@chromium.org,bradnelson@chr...
BUG=v8:6020

Review-Url: https://codereview.chromium.org/2728823005
Cr-Commit-Position: refs/heads/master@{#43562}
Committed:
https://chromium.googlesource.com/v8/v8/+/8b130a8495232a4c1a349256a0e2a3cc4b0...
==========

[commit-bot: I haz the power, 2017-03-03 02:31:50]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/8b130a8495232a4c1a349256a0e2a3cc4b0...