Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2718323003: [wasm]implement simd lowering for f32x4->i32x4, i32x4 min/max and shift instructions (Closed)

Created:
3 years, 9 months ago by aseemgarg
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm]implement simd lowering for f32x4->i32x4, i32x4 min/max and shift instructions BUG=v8:4124 R=bradnelson@chromium.org,bbudge@chromium.org,gdeepti@chromium.org,mtrofin@chromium.org,titzer@chromium.org Review-Url: https://codereview.chromium.org/2718323003 Cr-Commit-Position: refs/heads/master@{#43510} Committed: https://chromium.googlesource.com/v8/v8/+/f75748cf4ca696fff268787068419604815f8090

Patch Set 1 #

Total comments: 4

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -12 lines) Patch
M src/compiler/simd-scalar-lowering.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/simd-scalar-lowering.cc View 1 5 chunks +126 lines, -6 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-simd.cc View 6 chunks +9 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (8 generated)
aseemgarg
3 years, 9 months ago (2017-02-28 13:46:54 UTC) #1
titzer
lgtm with nits https://codereview.chromium.org/2718323003/diff/1/src/compiler/simd-scalar-lowering.cc File src/compiler/simd-scalar-lowering.cc (right): https://codereview.chromium.org/2718323003/diff/1/src/compiler/simd-scalar-lowering.cc#newcode123 src/compiler/simd-scalar-lowering.cc:123: default: { Probably time for an ...
3 years, 9 months ago (2017-03-01 09:40:29 UTC) #6
aseemgarg
https://codereview.chromium.org/2718323003/diff/1/src/compiler/simd-scalar-lowering.cc File src/compiler/simd-scalar-lowering.cc (right): https://codereview.chromium.org/2718323003/diff/1/src/compiler/simd-scalar-lowering.cc#newcode123 src/compiler/simd-scalar-lowering.cc:123: default: { On 2017/03/01 09:40:28, titzer wrote: > Probably ...
3 years, 9 months ago (2017-03-01 10:55:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718323003/20001
3 years, 9 months ago (2017-03-01 11:13:51 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/f75748cf4ca696fff268787068419604815f8090
3 years, 9 months ago (2017-03-01 11:39:16 UTC) #13
Michael Achenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2723943003/ by machenbach@chromium.org. ...
3 years, 9 months ago (2017-03-01 12:39:31 UTC) #14
ahaas
3 years, 9 months ago (2017-03-01 12:39:51 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2725853002/ by ahaas@chromium.org.

The reason for reverting is: There is a crash on a bot
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds....

Powered by Google App Engine
This is Rietveld 408576698