third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp - Issue 2724333002: Get rid of VisibleSelection::firstRangeOf()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

Issue 2724333002: Get rid of VisibleSelection::firstRangeOf() (Closed)

Patch Set: 2017-03-03T13:18:27 DCHECK(!range) => DCHECK(range) Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

index 25c2a686736e20807710278f61da12646ff56662..abc30a137ba306c3b7dca054bef7e28d69c62d06 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

@@ -1791,7 +1791,7 @@ AXObject::AXRange AXLayoutObject::selectionUnderObject() const {

->frame()

->selection()

.computeVisibleSelectionInDOMTreeDeprecated();

- Range* selectionRange = firstRangeOf(selection);

+ Range* selectionRange = createRange(firstEphemeralRangeOf(selection));

ContainerNode* parentNode = getNode()->parentNode();

int nodeIndex = getNode()->nodeIndex();

if (!selectionRange