third_party/WebKit/Source/core/editing/SelectionEditor.cpp - Issue 2724333002: Get rid of VisibleSelection::firstRangeOf()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/SelectionEditor.cpp

Issue 2724333002: Get rid of VisibleSelection::firstRangeOf() (Closed)

Patch Set: 2017-03-03T13:18:27 DCHECK(!range) => DCHECK(range) Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/SelectionEditor.cpp

diff --git a/third_party/WebKit/Source/core/editing/SelectionEditor.cpp b/third_party/WebKit/Source/core/editing/SelectionEditor.cpp

index cbf5174bbe79a2e473cd2bfea18c64318f559894..a06bc771a81ae07c735ce3bf5af79e7c00e81880 100644

--- a/third_party/WebKit/Source/core/editing/SelectionEditor.cpp

+++ b/third_party/WebKit/Source/core/editing/SelectionEditor.cpp

@@ -368,7 +368,7 @@ void SelectionEditor::setLogicalRange(Range* range) {

Range* SelectionEditor::firstRange() const {

if (m_logicalRange)

return m_logicalRange->cloneRange();

- return firstRangeOf(computeVisibleSelectionInDOMTree());

+ return createRange(firstEphemeralRangeOf(computeVisibleSelectionInDOMTree()));

}

bool SelectionEditor::shouldAlwaysUseDirectionalSelection() const {