third_party/WebKit/Source/core/editing/VisibleSelection.h - Issue 2724333002: Get rid of VisibleSelection::firstRangeOf()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.h

Issue 2724333002: Get rid of VisibleSelection::firstRangeOf() (Closed)

Patch Set: 2017-03-03T13:18:27 DCHECK(!range) => DCHECK(range) Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/VisibleSelection.h

diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.h b/third_party/WebKit/Source/core/editing/VisibleSelection.h

index b42326194fe6c56ee098651fd24463ef8836de52..09a430aae77878c8159004d925b06a516840a12b 100644

--- a/third_party/WebKit/Source/core/editing/VisibleSelection.h

+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.h

@@ -196,9 +196,6 @@ createVisibleSelection(const SelectionInFlatTree&);

// to return.

CORE_EXPORT EphemeralRange firstEphemeralRangeOf(const VisibleSelection&);

-// TODO(sof): move more firstRangeOf() uses to be over EphemeralRange instead.

-CORE_EXPORT Range* firstRangeOf(const VisibleSelection&);

CORE_EXPORT std::ostream& operator<<(std::ostream&, const VisibleSelection&);

CORE_EXPORT std::ostream& operator<<(std::ostream&,

const VisibleSelectionInFlatTree&);