Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2723253002: Fix beep when navigating/closing a page with find bar open

Created:
3 years, 9 months ago by scottmg
Modified:
3 years, 9 months ago
Reviewers:
paulmeyer
CC:
chromium-reviews, extensions-reviews_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix beep when navigating/closing a page with find bar open This regressed at https://codereview.chromium.org/1959183002 when oopif find was implemented. This plumbs through the fact that the notification is coming from a frame removal, and doesn't play a sound in that case. R=paulmeyer@chromium.org BUG=682299 TEST=FindRequestManagerTest.RemoveFrame added

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : try executing test #

Patch Set 4 : android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -55 lines) Patch
M android_webview/native/aw_web_contents_delegate.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/native/aw_web_contents_delegate.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_notification_details.h View 2 chunks +17 lines, -10 lines 0 comments Download
M chrome/browser/ui/find_bar/find_tab_helper.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_tab_helper.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/guest_view/browser/guest_view_base.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/guest_view/browser/guest_view_base.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M content/browser/download/mhtml_generation_browsertest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/find_request_manager.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/find_request_manager.cc View 7 chunks +15 lines, -7 lines 0 comments Download
M content/browser/find_request_manager_browsertest.cc View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/test/find_test_utils.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M content/public/test/find_test_utils.cc View 1 2 3 chunks +10 lines, -6 lines 0 comments Download
A content/test/data/find_with_frame_removal.html View 1 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.h View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (19 generated)
scottmg
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-01 19:50:19 UTC) #1
scottmg
Description was changed from ========== Fix beep when navigating/closing a page with find bar open ...
3 years, 9 months ago (2017-03-01 19:50:29 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723253002/1
3 years, 9 months ago (2017-03-01 19:50:52 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-01 20:05:00 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/319076) linux_chromium_chromeos_ozone_rel_ng on ...
3 years, 9 months ago (2017-03-01 20:05:01 UTC) #5
scottmg
Description was changed from ========== Fix beep when navigating/closing a page with find bar open ...
3 years, 9 months ago (2017-03-01 20:17:33 UTC) #6
scottmg
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-01 20:19:59 UTC) #7
scottmg
Patchset #2 (id:20001) has been deleted
3 years, 9 months ago (2017-03-01 20:20:11 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723253002/1
3 years, 9 months ago (2017-03-01 20:20:51 UTC) #9
scottmg
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-01 20:28:31 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723253002/40001
3 years, 9 months ago (2017-03-01 20:29:19 UTC) #11
scottmg
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-01 20:45:40 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723253002/60001
3 years, 9 months ago (2017-03-01 20:46:14 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-01 21:16:18 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/128917) linux_android_rel_ng on ...
3 years, 9 months ago (2017-03-01 21:16:19 UTC) #15
scottmg
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-01 21:18:04 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723253002/80001
3 years, 9 months ago (2017-03-01 21:18:34 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-01 21:44:17 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 21:44:18 UTC) #19 
Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

Powered by Google App Engine
This is Rietveld 408576698