extensions/browser/guest_view/web_view/web_view_guest.h - Issue 2723253002: Fix beep when navigating/closing a page with find bar open

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.h

Issue 2723253002: Fix beep when navigating/closing a page with find bar open

Patch Set: android Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/web_view/web_view_guest.h

diff --git a/extensions/browser/guest_view/web_view/web_view_guest.h b/extensions/browser/guest_view/web_view/web_view_guest.h

index 2a3befd59ff9723a07691a771b77fe4402961f3c..74cf8a208e7d5546a06a2d6a701363d6e297b362 100644

--- a/extensions/browser/guest_view/web_view/web_view_guest.h

+++ b/extensions/browser/guest_view/web_view/web_view_guest.h

@@ -178,7 +178,8 @@ class WebViewGuest : public guest_view::GuestView<WebViewGuest>,

int number_of_matches,

const gfx::Rect& selection_rect,

int active_match_ordinal,

- bool final_update) final;

+ bool final_update,

+ bool was_frame_removal) final;

bool ZoomPropagatesFromEmbedderToGuest() const final;

const char* GetAPINamespace() const final;

int GetTaskPrefix() const final;