Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7754)

Unified Diff: chrome/browser/ui/find_bar/find_bar_controller.cc

Issue 2723253002: Fix beep when navigating/closing a page with find bar open
Patch Set: android Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/find_bar/find_notification_details.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/find_bar/find_bar_controller.cc
diff --git a/chrome/browser/ui/find_bar/find_bar_controller.cc b/chrome/browser/ui/find_bar/find_bar_controller.cc
index db9cfcefd123182f20140dccf9165747410969e3..2f4ba05a0a1a10e5a12c9c9c78452aff203888e7 100644
--- a/chrome/browser/ui/find_bar/find_bar_controller.cc
+++ b/chrome/browser/ui/find_bar/find_bar_controller.cc
@@ -140,7 +140,8 @@ void FindBarController::Observe(int type,
if (content::Source<WebContents>(source).ptr() == web_contents_) {
UpdateFindBarForCurrentResult();
if (find_tab_helper->find_result().final_update() &&
- find_tab_helper->find_result().number_of_matches() == 0) {
+ find_tab_helper->find_result().number_of_matches() == 0 &&
+ !find_tab_helper->find_result().was_frame_removal()) {
const base::string16& last_search =
find_tab_helper->previous_find_text();
const base::string16& current_search = find_tab_helper->find_text();
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/find_bar/find_notification_details.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698