Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: components/guest_view/browser/guest_view_base.h

Issue 2723253002: Fix beep when navigating/closing a page with find bar open
Patch Set: android Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_GUEST_VIEW_BROWSER_GUEST_VIEW_BASE_H_ 5 #ifndef COMPONENTS_GUEST_VIEW_BROWSER_GUEST_VIEW_BASE_H_
6 #define COMPONENTS_GUEST_VIEW_BROWSER_GUEST_VIEW_BASE_H_ 6 #define COMPONENTS_GUEST_VIEW_BROWSER_GUEST_VIEW_BASE_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <queue> 9 #include <queue>
10 10
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 void HandleKeyboardEvent( 220 void HandleKeyboardEvent(
221 content::WebContents* source, 221 content::WebContents* source,
222 const content::NativeWebKeyboardEvent& event) override; 222 const content::NativeWebKeyboardEvent& event) override;
223 bool PreHandleGestureEvent(content::WebContents* source, 223 bool PreHandleGestureEvent(content::WebContents* source,
224 const blink::WebGestureEvent& event) override; 224 const blink::WebGestureEvent& event) override;
225 void FindReply(content::WebContents* source, 225 void FindReply(content::WebContents* source,
226 int request_id, 226 int request_id,
227 int number_of_matches, 227 int number_of_matches,
228 const gfx::Rect& selection_rect, 228 const gfx::Rect& selection_rect,
229 int active_match_ordinal, 229 int active_match_ordinal,
230 bool final_update) override; 230 bool final_update,
231 bool was_frame_removal) override;
231 232
232 // WebContentsObserver implementation. 233 // WebContentsObserver implementation.
233 void DidFinishNavigation( 234 void DidFinishNavigation(
234 content::NavigationHandle* navigation_handle) override; 235 content::NavigationHandle* navigation_handle) override;
235 236
236 // Given a set of initialization parameters, a concrete subclass of 237 // Given a set of initialization parameters, a concrete subclass of
237 // GuestViewBase can create a specialized WebContents that it returns back to 238 // GuestViewBase can create a specialized WebContents that it returns back to
238 // GuestViewBase. 239 // GuestViewBase.
239 virtual void CreateWebContents( 240 virtual void CreateWebContents(
240 const base::DictionaryValue& create_params, 241 const base::DictionaryValue& create_params,
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
486 // This is used to ensure pending tasks will not fire after this object is 487 // This is used to ensure pending tasks will not fire after this object is
487 // destroyed. 488 // destroyed.
488 base::WeakPtrFactory<GuestViewBase> weak_ptr_factory_; 489 base::WeakPtrFactory<GuestViewBase> weak_ptr_factory_;
489 490
490 DISALLOW_COPY_AND_ASSIGN(GuestViewBase); 491 DISALLOW_COPY_AND_ASSIGN(GuestViewBase);
491 }; 492 };
492 493
493 } // namespace guest_view 494 } // namespace guest_view
494 495
495 #endif // COMPONENTS_GUEST_VIEW_BROWSER_GUEST_VIEW_BASE_H_ 496 #endif // COMPONENTS_GUEST_VIEW_BROWSER_GUEST_VIEW_BASE_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/find_bar/find_tab_helper.cc ('k') | components/guest_view/browser/guest_view_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698