Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: chrome/browser/ui/find_bar/find_notification_details.h

Issue 2723253002: Fix beep when navigating/closing a page with find bar open
Patch Set: android Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/find_bar/find_bar_controller.cc ('k') | chrome/browser/ui/find_bar/find_tab_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/find_bar/find_notification_details.h
diff --git a/chrome/browser/ui/find_bar/find_notification_details.h b/chrome/browser/ui/find_bar/find_notification_details.h
index b2b6fdf44c71dd1ba8624abef44e8b614f536ead..a655089a57d5daeece996e72139d07e3321af376 100644
--- a/chrome/browser/ui/find_bar/find_notification_details.h
+++ b/chrome/browser/ui/find_bar/find_notification_details.h
@@ -13,18 +13,21 @@ class FindNotificationDetails {
int number_of_matches,
const gfx::Rect& selection_rect,
int active_match_ordinal,
- bool final_update)
- : request_id_(request_id),
- number_of_matches_(number_of_matches),
- selection_rect_(selection_rect),
- active_match_ordinal_(active_match_ordinal),
- final_update_(final_update) {}
+ bool final_update,
+ bool was_frame_removal)
+ : request_id_(request_id),
+ number_of_matches_(number_of_matches),
+ selection_rect_(selection_rect),
+ active_match_ordinal_(active_match_ordinal),
+ final_update_(final_update),
+ was_frame_removal_(was_frame_removal) {}
FindNotificationDetails()
- : request_id_(0),
- number_of_matches_(-1),
- active_match_ordinal_(-1),
- final_update_(false) {}
+ : request_id_(0),
+ number_of_matches_(-1),
+ active_match_ordinal_(-1),
+ final_update_(false),
+ was_frame_removal_(false) {}
~FindNotificationDetails() {}
@@ -38,12 +41,16 @@ class FindNotificationDetails {
bool final_update() const { return final_update_; }
+ bool was_frame_removal() const { return was_frame_removal_; }
+
private:
int request_id_; // The find-in-page request whose results we're returning.
int number_of_matches_; // How many matches were found.
gfx::Rect selection_rect_; // Where selection occurred (screen coordinate).
int active_match_ordinal_; // The ordinal of the currently selected match.
bool final_update_; // Whether this is the last Find Result update.
+ bool was_frame_removal_; // Whether the update is due to a frame being
+ // removed.
};
#endif // CHROME_BROWSER_UI_FIND_BAR_FIND_NOTIFICATION_DETAILS_H_
« no previous file with comments | « chrome/browser/ui/find_bar/find_bar_controller.cc ('k') | chrome/browser/ui/find_bar/find_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698