Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 2723023003: Revert of [LayoutNG] Move remaining ng_units structs to their own files (Closed)

Created:
3 years, 9 months ago by Adam Rice
Modified:
3 years, 9 months ago
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [LayoutNG] Move remaining ng_units structs to their own files (patchset #6 id:120001 of https://codereview.chromium.org/2721613003/ ) Reason for revert: Causing link error on Android due to duplicate symbols: https://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/104531 Original issue's description: > [LayoutNG] Move remaining ng_units structs to their own files > > R=mstensho@opera.com > > Review-Url: https://codereview.chromium.org/2721613003 > Cr-Commit-Position: refs/heads/master@{#453878} > Committed: https://chromium.googlesource.com/chromium/src/+/480fa30589acd71427e3f902fd7916e87c41f5d9 TBR=mstensho@opera.com,eae@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2723023003 Cr-Commit-Position: refs/heads/master@{#453880} Committed: https://chromium.googlesource.com/chromium/src/+/b2d6da67bc1594a8a11c26167e9aeba37369e729

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+624 lines, -797 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/BUILD.gn View 5 chunks +2 lines, -13 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/geometry/ng_box_strut.h View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/geometry/ng_box_strut.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/geometry/ng_box_strut_test.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/geometry/ng_edge.h View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_rect.h View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_rect.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_size.h View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/layout/ng/geometry/ng_margin_strut.h View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/geometry/ng_margin_strut.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/geometry/ng_static_position.h View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/geometry/ng_static_position.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.h View 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc View 6 chunks +19 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 6 chunks +18 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_box_fragment.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_exclusion.h View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_exclusion.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_floating_object.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_tree_node.h View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_result.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.h View 6 chunks +12 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc View 8 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc View 7 chunks +18 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_line_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_min_max_content_size.h View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_min_max_content_size.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_min_max_content_size_test.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h View 1 chunk +1 line, -2 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_units.h View 1 chunk +268 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_units.cc View 1 chunk +161 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_units_test.cc View 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Adam Rice
Created Revert of [LayoutNG] Move remaining ng_units structs to their own files
3 years, 9 months ago (2017-03-01 08:15:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723023003/1
3 years, 9 months ago (2017-03-01 08:15:45 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 08:17:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b2d6da67bc1594a8a11c26167e9a...

Powered by Google App Engine
This is Rietveld 408576698