[LayoutNG] Switch NGBreakToken to being RefCounted.

[LayoutNG] Switch NGBreakToken to being RefCounted.

After the fragmenting switch ownership of breaktokens is clearer,
and this just swtiches them to being refcounted.

Shouldn't have any behaviour changes.

BUG=635619
Review-Url: https://codereview.chromium.org/2722763002
Cr-Commit-Position: refs/heads/master@{#454381}
Committed: https://chromium.googlesource.com/chromium/src/+/e2cdb910981e41e82987ca6d46ac64633e42637d

[ikilpatrick, 2017-02-28 17:09:35]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 17:09:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2017-02-28 17:11:15]

Description was changed from

==========
[LayoutNG] Switch break tokens to being RefCounted.

BUG=
==========

to

==========
[LayoutNG] NGBreakToken to being RefCounted.

After the fragmenting switch ownership of breaktokens is clearer,
and this just swtiches them to being refcounted.

Shouldn't have any behaviour changes.

BUG=635619
==========

[ikilpatrick, 2017-02-28 17:11:29]

ikilpatrick@chromium.org changed reviewers:
+ cbiesinger@chromium.org

[ikilpatrick, 2017-02-28 17:13:13]

https://codereview.chromium.org/2722763002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_block_child_iterator.h (right):

https://codereview.chromium.org/2722763002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_child_iterator.h:37:
NGBlockBreakToken* break_token_;  // Not-owned as STACK_ALLOCATED.
it'd be nice if we had a class like:
NotARefPtrBecuaseStackAllocated<>

https://codereview.chromium.org/2722763002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h
(right):

https://codereview.chromium.org/2722763002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h:92:
RefPtr<NGBlockBreakToken> break_token_;
I could also make this a raw ptr? (and other alg. classes).

[commit-bot: I haz the power, 2017-02-28 18:46:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 18:46:13]

Dry run: This issue passed the CQ dry run.

[ikilpatrick, 2017-03-02 17:34:12]

Description was changed from

==========
[LayoutNG] NGBreakToken to being RefCounted.

After the fragmenting switch ownership of breaktokens is clearer,
and this just swtiches them to being refcounted.

Shouldn't have any behaviour changes.

BUG=635619
==========

to

==========
[LayoutNG] Switch NGBreakToken to being RefCounted.

After the fragmenting switch ownership of breaktokens is clearer,
and this just swtiches them to being refcounted.

Shouldn't have any behaviour changes.

BUG=635619
==========

[ikilpatrick, 2017-03-02 17:34:17]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 17:34:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 19:34:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 19:34:06]

Dry run: This issue passed the CQ dry run.

[ikilpatrick, 2017-03-02 19:53:49]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[ikilpatrick, 2017-03-02 19:54:04]

ptal :)

[commit-bot: I haz the power, 2017-03-02 19:54:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2017-03-02 20:35:47]

lgtm, sorry. not sure how I missed this

[ikilpatrick, 2017-03-02 20:45:20]

np :)

[ikilpatrick, 2017-03-02 20:52:16]

The CQ bit was unchecked by ikilpatrick@chromium.org

[ikilpatrick, 2017-03-02 20:52:23]

The CQ bit was checked by ikilpatrick@chromium.org

[commit-bot: I haz the power, 2017-03-02 20:52:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 21:29:46]

CQ is committing da patch.

Bot data: {"patchset_id": 60002, "attempt_start_ts": 1488487943140410,
"parent_rev": "2e7ded925d16d7e4c7c406f15b887520d5c2a71f", "commit_rev":
"e2cdb910981e41e82987ca6d46ac64633e42637d"}

[commit-bot: I haz the power, 2017-03-02 21:30:27]

Description was changed from

==========
[LayoutNG] Switch NGBreakToken to being RefCounted.

After the fragmenting switch ownership of breaktokens is clearer,
and this just swtiches them to being refcounted.

Shouldn't have any behaviour changes.

BUG=635619
==========

to

==========
[LayoutNG] Switch NGBreakToken to being RefCounted.

After the fragmenting switch ownership of breaktokens is clearer,
and this just swtiches them to being refcounted.

Shouldn't have any behaviour changes.

BUG=635619

Review-Url: https://codereview.chromium.org/2722763002
Cr-Commit-Position: refs/heads/master@{#454381}
Committed:
https://chromium.googlesource.com/chromium/src/+/e2cdb910981e41e82987ca6d46ac...
==========

[commit-bot: I haz the power, 2017-03-02 21:30:28]

Committed patchset #7 (id:60002) as
https://chromium.googlesource.com/chromium/src/+/e2cdb910981e41e82987ca6d46ac...