Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h

Issue 2722763002: [LayoutNG] Switch NGBreakToken to being RefCounted. (Closed)
Patch Set: remove comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h b/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h
index c2d626b9c3d754c6ae1cb4116597d14da5ee80ad..cea8301f35cb9b4eac2452f4290b4d14a8899e90 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h
@@ -6,16 +6,17 @@
#define NGPhysicalFragment_h
#include "core/CoreExport.h"
+#include "core/layout/ng/ng_break_token.h"
#include "core/layout/ng/ng_units.h"
#include "platform/LayoutUnit.h"
#include "platform/heap/Handle.h"
+#include "wtf/RefPtr.h"
#include "wtf/Vector.h"
namespace blink {
class ComputedStyle;
class LayoutObject;
-class NGBreakToken;
// The NGPhysicalFragment contains the output geometry from layout. The
// fragment stores all of its information in the physical coordinate system for
@@ -79,7 +80,7 @@ class CORE_EXPORT NGPhysicalFragment : public RefCounted<NGPhysicalFragment> {
is_placed_ = true;
}
- NGBreakToken* BreakToken() const { return break_token_; }
+ NGBreakToken* BreakToken() const { return break_token_.get(); }
const ComputedStyle& Style() const;
@@ -94,13 +95,13 @@ class CORE_EXPORT NGPhysicalFragment : public RefCounted<NGPhysicalFragment> {
NGPhysicalSize size,
NGPhysicalSize overflow,
NGFragmentType type,
- NGBreakToken* break_token = nullptr);
+ RefPtr<NGBreakToken> break_token = nullptr);
LayoutObject* layout_object_;
NGPhysicalSize size_;
NGPhysicalSize overflow_;
NGPhysicalOffset offset_;
- Persistent<NGBreakToken> break_token_;
+ RefPtr<NGBreakToken> break_token_;
unsigned type_ : 1;
unsigned is_placed_ : 1;

Powered by Google App Engine
This is Rietveld 408576698