Add Select All to Android floating insertion menu

Add Select All to Android floating insertion menu

Currently the insertion paste popup menu doesn't have the "Select All" option which
is a mismatch from how the native Android menu works.

BUG=615435
Review-Url: https://codereview.chromium.org/2722273002
Cr-Commit-Position: refs/heads/master@{#464106}
Committed: https://chromium.googlesource.com/chromium/src/+/8bf0dbc4326668e5a12f974f783e5543b78fe4f9

[amaralp, 2017-03-01 19:45:21]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 19:46:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 20:34:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 20:34:05]

Dry run: This issue passed the CQ dry run.

[amaralp, 2017-03-02 01:02:54]

Description was changed from

==========
Add Select All to Android floating insertion menu

BUG=615435
==========

to

==========
Add Select All to Android floating insertion menu

Currently the insertion paste popup menu doesn't have the "Select All" option
which
is a mismatch from how the native Android menu works.

BUG=615435
==========

[amaralp, 2017-03-02 01:02:55]

amaralp@chromium.org changed reviewers:
+ aelias@chromium.org, boliu@chromium.org

[amaralp, 2017-03-02 04:39:35]

Patchset #3 (id:40001) has been deleted

[amaralp, 2017-04-07 06:42:42]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 06:42:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[amaralp, 2017-04-07 07:33:30]

PTAL

[commit-bot: I haz the power, 2017-04-07 07:34:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 07:34:24]

Dry run: This issue passed the CQ dry run.

[boliu, 2017-04-07 17:33:14]

test?

https://codereview.chromium.org/2722273002/diff/60001/content/browser/DEPS
File content/browser/DEPS (right):

https://codereview.chromium.org/2722273002/diff/60001/content/browser/DEPS#ne...
content/browser/DEPS:115: "+third_party/WebKit/public/web/WebContextMenuData.h",
I guess Alex can decide if EditFlags should be factored out into its own header
so everything else here is not all pulled in as well

https://codereview.chromium.org/2722273002/diff/60001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
(right):

https://codereview.chromium.org/2722273002/diff/60001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java:273:
public void selectAll() {
override

[amaralp, 2017-04-07 19:45:40]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 19:46:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 19:56:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 19:56:08]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[amaralp, 2017-04-07 21:14:40]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 21:15:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 21:25:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 21:25:49]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[amaralp, 2017-04-08 00:29:04]

On 2017/04/07 at 17:33:14, boliu wrote:
> test?
> 
Added tests.
>
https://codereview.chromium.org/2722273002/diff/60001/content/public/android/...
>
content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java:273:
public void selectAll() {
> override
Done.

[boliu, 2017-04-08 00:33:11]

https://codereview.chromium.org/2722273002/diff/80002/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
(right):

https://codereview.chromium.org/2722273002/diff/80002/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java:105:
private boolean mCanSelectAll;
ForPastePopup? or add a comment this isn't an additional state, just a status
for PastPopup that's saved for testing

[aelias_OOO_until_Jul13, 2017-04-08 00:33:52]

lgtm, thanks!

[boliu, 2017-04-08 00:38:53]

lgtm % that last comment

[amaralp, 2017-04-08 00:56:47]

The CQ bit was checked by amaralp@chromium.org

[amaralp, 2017-04-08 00:56:48]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2722273002/#ps110001
(title: "Renamed bool")

[commit-bot: I haz the power, 2017-04-08 00:57:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 02:37:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-08 02:37:41]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[amaralp, 2017-04-10 20:09:40]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 20:10:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 21:12:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 21:12:18]

Dry run: This issue passed the CQ dry run.

[amaralp, 2017-04-10 21:25:38]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 21:26:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 23:17:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 23:17:07]

Dry run: This issue passed the CQ dry run.

[amaralp, 2017-04-12 01:35:24]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 01:36:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 02:16:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 02:16:10]

Dry run: This issue passed the CQ dry run.

[amaralp, 2017-04-12 18:47:56]

The CQ bit was checked by amaralp@chromium.org

[amaralp, 2017-04-12 18:47:57]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2722273002/#ps170001
(title: "moving input location")

[commit-bot: I haz the power, 2017-04-12 18:48:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 19:26:34]

CQ is committing da patch.

Bot data: {"patchset_id": 170001, "attempt_start_ts": 1492022876629280,
"parent_rev": "0951bca32b2f1a57f43c19ad865623cddbd144cf", "commit_rev":
"8bf0dbc4326668e5a12f974f783e5543b78fe4f9"}

[commit-bot: I haz the power, 2017-04-12 19:27:27]

Description was changed from

==========
Add Select All to Android floating insertion menu

Currently the insertion paste popup menu doesn't have the "Select All" option
which
is a mismatch from how the native Android menu works.

BUG=615435
==========

to

==========
Add Select All to Android floating insertion menu

Currently the insertion paste popup menu doesn't have the "Select All" option
which
is a mismatch from how the native Android menu works.

BUG=615435

Review-Url: https://codereview.chromium.org/2722273002
Cr-Commit-Position: refs/heads/master@{#464106}
Committed:
https://chromium.googlesource.com/chromium/src/+/8bf0dbc4326668e5a12f974f783e...
==========

[commit-bot: I haz the power, 2017-04-12 19:27:28]

Committed patchset #9 (id:170001) as
https://chromium.googlesource.com/chromium/src/+/8bf0dbc4326668e5a12f974f783e...

[amaralp, 2017-04-13 18:22:57]

Patchset #10 (id:190001) has been deleted