Issue 2713543002: Only focus if contextmenu event was sent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2713543002: Only focus if contextmenu event was sent (Closed)

Created:
3 years, 10 months ago by amaralp

Modified:
3 years, 6 months ago

Reviewers:

CC:
chromium-reviews, blink-reviews, dtapuska+blinkwatch_chromium.org, Navid Zolghadr

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Only focus if contextmenu event was sent BUG=

Patch Set 1 #

Patch Set 2 : Dragging selection handle should create a new action mode #

Patch Set 3 : Adding double/triple click to Android #

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -4 lines)			Patch
	M	content/browser/renderer_host/render_widget_host_view_android.h	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	content/browser/renderer_host/render_widget_host_view_android.cc	View	1 2	3 chunks	+26 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

amaralp

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

3 years, 10 months ago (2017-02-22 00:53:42 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713543002/1

3 years, 10 months ago (2017-02-22 00:55:38 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 10 months ago (2017-02-22 02:58:04 UTC) #3

commit-bot: I haz the power

3 years, 10 months ago (2017-02-22 02:58:05 UTC) #4

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages