content/public/android/java/src/org/chromium/content/browser/input/FloatingPastePopupMenu.java - Issue 2722273002: Add Select All to Android floating insertion menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/FloatingPastePopupMenu.java

Issue 2722273002: Add Select All to Android floating insertion menu (Closed)

Patch Set: moving input location Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java ('k') | content/public/android/java/src/org/chromium/content/browser/input/PastePopupMenu.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/FloatingPastePopupMenu.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/FloatingPastePopupMenu.java b/content/public/android/java/src/org/chromium/content/browser/input/FloatingPastePopupMenu.java

index 3c41da5c53962a9e173365add8798777d3f9faab..f48e3e4f0163f90f569070001fcddac613d0156c 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/FloatingPastePopupMenu.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/FloatingPastePopupMenu.java

@@ -108,7 +108,7 @@ public class FloatingPastePopupMenu implements PastePopupMenu {

mode.setSubtitle(null);

SelectionPopupController.initializeMenu(mContext, mode, menu);

if (!mDelegate.canPaste()) menu.removeItem(R.id.select_action_menu_paste);

- menu.removeItem(R.id.select_action_menu_select_all);

+ if (!mDelegate.canSelectAll()) menu.removeItem(R.id.select_action_menu_select_all);

menu.removeItem(R.id.select_action_menu_cut);

menu.removeItem(R.id.select_action_menu_copy);

menu.removeItem(R.id.select_action_menu_share);

@@ -126,6 +126,10 @@ public class FloatingPastePopupMenu implements PastePopupMenu {

mDelegate.paste();

mode.finish();

}

+ if (item.getItemId() == R.id.select_action_menu_select_all) {

+ mDelegate.selectAll();

+ mode.finish();

+ }

return true;

}