content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 2722273002: Add Select All to Android floating insertion menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2722273002: Add Select All to Android floating insertion menu (Closed)

Patch Set: moving input location Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/content_view_core_impl.cc ('k') | content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 445312965ac5a6be50d33a5e9662be89582bf1ad..7eee9cfbbd7ab41ca5fe37f372051e042f8b461e 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -1890,8 +1890,8 @@ public class ContentViewCore

}

@CalledByNative

- private void showPastePopup(int x, int y) {

- mSelectionPopupController.createAndShowPastePopup(x, y);

+ private void showPastePopup(int x, int y, boolean canSelectAll) {

+ mSelectionPopupController.createAndShowPastePopup(x, y, canSelectAll);

}

private void destroyPastePopup() {