Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2721473003: Renaming FrameLoaderClient with LocalFrameClient for files in core/html (Closed)

Created:
3 years, 9 months ago by slangley
Modified:
3 years, 9 months ago
Reviewers:
haraken, joelhockey
CC:
blink-reviews-frames_chromium.org, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gavinp+prerender_chromium.org, gasubic, kenneth.christiansen, mlamouri+watch-blink_chromium.org, nessy, Srirama, Yoav Weiss
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace FrameLoaderClient.h with LocalFrameClient.h and replace usage of FrameLoaderClient with LocalFrameClient for files located under third_party/WebKit/Source/core/html. *** This is just a rename CL - There are no logic changes *** BUG=694773 Review-Url: https://codereview.chromium.org/2721473003 Cr-Commit-Position: refs/heads/master@{#453136} Committed: https://chromium.googlesource.com/chromium/src/+/d7e0002a7d8f98fe00f51a9d187816cdab1c527e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElementWithState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 5 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMetaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
slangley
3 years, 9 months ago (2017-02-26 23:09:59 UTC) #2
joelhockey
lgtm
3 years, 9 months ago (2017-02-27 00:08:31 UTC) #3
slangley
haraken@ - ptal
3 years, 9 months ago (2017-02-27 00:10:19 UTC) #5
haraken
LGTM Put a CL title on the first line of the CL description.
3 years, 9 months ago (2017-02-27 00:15:17 UTC) #6
haraken
BTW, what is blink-frame-reviews@chromium.org? I cannot find the group in chromium.org...? (The list I created ...
3 years, 9 months ago (2017-02-27 00:19:43 UTC) #7
slangley
On 2017/02/27 at 00:19:43, haraken wrote: > BTW, what is blink-frame-reviews@chromium.org? I cannot find the ...
3 years, 9 months ago (2017-02-27 00:21:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721473003/1
3 years, 9 months ago (2017-02-27 00:22:50 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 01:54:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d7e0002a7d8f98fe00f51a9d1878...

Powered by Google App Engine
This is Rietveld 408576698