Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1266)

Unified Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 2721503002: Rename all uses of EmptyFrameLoaderClient with EmptyLocalFrameClient. (Closed)
Patch Set: Change V8 headers to user includes and introduce a space between system and user headers. Headers w… Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/InspectorOverlay.cpp
diff --git a/third_party/WebKit/Source/web/InspectorOverlay.cpp b/third_party/WebKit/Source/web/InspectorOverlay.cpp
index 721586a109fdec65fd224caa18656e2f2b02a70a..b7d9e4c6b20db89c1675c6e4e9844b926214af48 100644
--- a/third_party/WebKit/Source/web/InspectorOverlay.cpp
+++ b/third_party/WebKit/Source/web/InspectorOverlay.cpp
@@ -28,6 +28,8 @@
#include "web/InspectorOverlay.h"
+#include <memory>
+
#include "bindings/core/v8/ScriptController.h"
#include "bindings/core/v8/ScriptSourceCode.h"
#include "bindings/core/v8/V8InspectorOverlayHost.h"
@@ -36,6 +38,7 @@
#include "core/frame/FrameHost.h"
#include "core/frame/FrameView.h"
#include "core/frame/LocalFrame.h"
+#include "core/frame/LocalFrameClient.h"
#include "core/frame/Settings.h"
#include "core/frame/VisualViewport.h"
#include "core/input/EventHandler.h"
@@ -50,13 +53,12 @@
#include "platform/graphics/paint/CullRect.h"
#include "public/platform/Platform.h"
#include "public/platform/WebData.h"
+#include "v8/include/v8.h"
#include "web/ChromeClientImpl.h"
#include "web/PageOverlay.h"
#include "web/WebInputEventConversion.h"
#include "web/WebLocalFrameImpl.h"
#include "wtf/AutoReset.h"
-#include <memory>
-#include <v8.h>
namespace blink {
@@ -502,8 +504,8 @@ Page* InspectorOverlay::overlayPage() {
ScriptForbiddenScope::AllowUserAgentScript allowScript;
- DEFINE_STATIC_LOCAL(FrameLoaderClient, dummyFrameLoaderClient,
- (EmptyFrameLoaderClient::create()));
+ DEFINE_STATIC_LOCAL(LocalFrameClient, dummyLocalFrameClient,
+ (EmptyLocalFrameClient::create()));
Page::PageClients pageClients;
fillWithEmptyClients(pageClients);
DCHECK(!m_overlayChromeClient);
@@ -538,7 +540,7 @@ Page* InspectorOverlay::overlayPage() {
// through some non-composited paint function.
overlaySettings.setAcceleratedCompositingEnabled(false);
- LocalFrame* frame = LocalFrame::create(&dummyFrameLoaderClient,
+ LocalFrame* frame = LocalFrame::create(&dummyLocalFrameClient,
&m_overlayPage->frameHost(), 0);
frame->setView(FrameView::create(*frame));
frame->init();

Powered by Google App Engine
This is Rietveld 408576698