Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2720633002: Move to core/frame/LocalFrameClient.h instead of core/loader/FrameLoaderClient.h (Closed)

Created:
3 years, 9 months ago by slangley
Modified:
3 years, 9 months ago
Reviewers:
haraken, joelhockey
CC:
blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, dshwang, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, eric.carlson_apple.com, falken+watch_chromium.org, feature-media-reviews_chromium.org, horo+watch_chromium.org, jchaffraix+rendering, jsbell+serviceworker_chromium.org, kinuko+worker_chromium.org, kinuko+watch, kinuko+serviceworker, leviw+renderwatch, loading-reviews+parser_chromium.org, michaeln, mlamouri+watch-blink_chromium.org, nhiroki, Navid Zolghadr, pdr+renderingwatchlist_chromium.org, serviceworker-reviews, shimazu+serviceworker_chromium.org, shimazu+worker_chromium.org, Srirama, szager+layoutwatch_chromium.org, tyoshino+watch_chromium.org, tzik, yhirano+watch_chromium.org, Yoav Weiss, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move to core/frame/LocalFrameClient.h instead of core/loader/FrameLoaderClient.h This only changes files where there we no other references to FrameLoaderClient, only the inclusion of the header file. *** This is a rename change only - there are no logic changes. *** BUG=694773 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2720633002 Cr-Commit-Position: refs/heads/master@{#453177} Committed: https://chromium.googlesource.com/chromium/src/+/de7db06819bf2fa12037d90e666bafe463a86d7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M third_party/WebKit/Source/core/html/ImageDocument.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/LinkManifest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/LinkStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/MediaDocument.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/PluginDocument.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 4 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/KeyboardEventManager.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/CookieJar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/NavigationScheduler.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ProgressTracker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/SharedWorker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XSLTProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/donottrack/NavigatorDoNotTrack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerClient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
slangley
3 years, 9 months ago (2017-02-27 02:14:32 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-02-27 02:16:50 UTC) #5
joelhockey
lgtm
3 years, 9 months ago (2017-02-27 03:14:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720633002/1
3 years, 9 months ago (2017-02-27 08:19:13 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 09:49:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/de7db06819bf2fa12037d90e666b...

Powered by Google App Engine
This is Rietveld 408576698