Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2715173002: Final rename from FrameLoaderClient to LocalFrameClient: (Closed)

Created:
3 years, 9 months ago by slangley
Modified:
3 years, 9 months ago
Reviewers:
haraken, joelhockey
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, bruening+watch_chromium.org, chromium-reviews, dglazkov+blink, dshwang, eae+blinkwatch, glider+watch_chromium.org, hongchan, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, Raymond Toy, sof, szager+layoutwatch_chromium.org, Yoav Weiss, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Final rename from FrameLoaderClient to LocalFrameClient: - Change all includes of FrameLoaderClient.h to LocalFrameClient.h - Update all references to LocalFrameClient and rename variables are required. - Remove FrameLoaderClient.h *** This is a rename CL only - there are not logic changes. *** BUG=694773 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2715173002 Cr-Commit-Position: refs/heads/master@{#453187} Committed: https://chromium.googlesource.com/chromium/src/+/16bd9a5826c9ff951b7f7def34c619b3a2d31858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -114 lines) Patch
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentUserGestureToken.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ElementVisibilityObserverTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 6 chunks +19 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTestHelper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/core/loader/FrameLoaderClient.h View 1 chunk +0 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentChecker.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoaderTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/PrintContextTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/VideoPainterTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/DummyPageHolder.h View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/testing/DummyPageHolder.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 2 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
slangley
3 years, 9 months ago (2017-02-27 03:34:11 UTC) #4
joelhockey
lgtm
3 years, 9 months ago (2017-02-27 03:37:22 UTC) #5
haraken
LGTM
3 years, 9 months ago (2017-02-27 03:52:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715173002/1
3 years, 9 months ago (2017-02-27 09:50:31 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 11:11:05 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/16bd9a5826c9ff951b7f7def34c6...

Powered by Google App Engine
This is Rietveld 408576698