Implement DeviceOrientationEvent constructor.

Implement DeviceOrientationEvent constructor.

This patch adds the DeviceOrientationEvent constructor as defined in the
spec:

https://w3c.github.io/deviceorientation/spec-source-orientation.html#deviceorientation

The DeviceOrientationEventInit IDL dictionary is added as a dependency.

BUG=651767
Review-Url: https://codereview.chromium.org/2720003003
Cr-Commit-Position: refs/heads/master@{#455234}
Committed: https://chromium.googlesource.com/chromium/src/+/e559b21a078a2f02e02613f5cbf805903bcd8a17

[Reilly Grant (use Gerrit), 2017-02-28 00:39:23]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[Reilly Grant (use Gerrit), 2017-02-28 00:39:41]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-02-28 00:40:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 02:34:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 02:34:53]

Dry run: This issue passed the CQ dry run.

[Reilly Grant (use Gerrit), 2017-02-28 19:38:41]

Description was changed from

==========
Implement DeviceOrientationEvent constructor.

This patch adds the DeviceOrientationEvent constructor as defined in the
spec:

https://w3c.github.io/deviceorientation/spec-source-orientation.html#deviceor...

The DeviceOrientationEventInit IDL dictionary is added as a dependency.

BUG=651767
==========

to

==========
Implement DeviceOrientationEvent constructor.

This patch adds the DeviceOrientationEvent constructor as defined in the
spec:

https://w3c.github.io/deviceorientation/spec-source-orientation.html#deviceor...

The DeviceOrientationEventInit IDL dictionary is added as a dependency.

BUG=651767
==========

[Reilly Grant (use Gerrit), 2017-02-28 19:38:42]

reillyg@chromium.org changed reviewers:
+ timvolodine@chromium.org

[Reilly Grant (use Gerrit), 2017-02-28 19:40:16]

reillyg@chromium.org changed reviewers:
+ esprehn@chromium.org

[Reilly Grant (use Gerrit), 2017-02-28 19:40:17]

timvolodine@, please review device_orientation changes.
esprehn@, please review modules_idl_files.gni.

[timvolodine, 2017-03-02 23:28:11]

lgtm, thanks

note: there is a CR version of the spec now..

https://codereview.chromium.org/2720003003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEventInit.idl
(right):

https://codereview.chromium.org/2720003003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEventInit.idl:5:
//
https://w3c.github.io/deviceorientation/spec-source-orientation.html#deviceor...
could you point this to CR instead of draft pls:
https://www.w3.org/TR/2016/CR-orientation-event-20160818/

[Reilly Grant (use Gerrit), 2017-03-03 01:49:05]

Reference Candidate Recommendation.

[Reilly Grant (use Gerrit), 2017-03-03 01:49:14]

https://codereview.chromium.org/2720003003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEventInit.idl
(right):

https://codereview.chromium.org/2720003003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEventInit.idl:5:
//
https://w3c.github.io/deviceorientation/spec-source-orientation.html#deviceor...
On 2017/03/02 23:28:11, timvolodine wrote:
> could you point this to CR instead of draft pls:
> https://www.w3.org/TR/2016/CR-orientation-event-20160818/

Done.

[Reilly Grant (use Gerrit), 2017-03-03 01:49:18]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 01:49:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-03-03 01:53:05]

Implementation-wise LGTM.

[commit-bot: I haz the power, 2017-03-03 03:22:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 03:22:08]

Dry run: This issue passed the CQ dry run.

[Reilly Grant (use Gerrit), 2017-03-06 18:35:54]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2017-03-06 18:35:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
timvolodine@chromium.org
Link to the patchset: https://codereview.chromium.org/2720003003/#ps40001
(title: "Reference Candidate Recommendation.")

[commit-bot: I haz the power, 2017-03-06 18:36:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 20:51:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 20:51:33]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Reilly Grant (use Gerrit), 2017-03-07 19:06:46]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2017-03-07 19:07:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 21:56:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488913606203650,
"parent_rev": "04f1cde4385303822f2fc977effa56402facb090", "commit_rev":
"e559b21a078a2f02e02613f5cbf805903bcd8a17"}

[commit-bot: I haz the power, 2017-03-07 21:57:13]

Description was changed from

==========
Implement DeviceOrientationEvent constructor.

This patch adds the DeviceOrientationEvent constructor as defined in the
spec:

https://w3c.github.io/deviceorientation/spec-source-orientation.html#deviceor...

The DeviceOrientationEventInit IDL dictionary is added as a dependency.

BUG=651767
==========

to

==========
Implement DeviceOrientationEvent constructor.

This patch adds the DeviceOrientationEvent constructor as defined in the
spec:

https://w3c.github.io/deviceorientation/spec-source-orientation.html#deviceor...

The DeviceOrientationEventInit IDL dictionary is added as a dependency.

BUG=651767

Review-Url: https://codereview.chromium.org/2720003003
Cr-Commit-Position: refs/heads/master@{#455234}
Committed:
https://chromium.googlesource.com/chromium/src/+/e559b21a078a2f02e02613f5cbf8...
==========

[commit-bot: I haz the power, 2017-03-07 21:57:14]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e559b21a078a2f02e02613f5cbf8...