Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl

Issue 2720003003: Implement DeviceOrientationEvent constructor. (Closed)
Patch Set: Reference Candidate Recommendation. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl
diff --git a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl
index e409fec25938693374201ca2e1cabd88e7705044..a50bfa684a4dad7b20701c0d5ccce2866043d5f8 100644
--- a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl
+++ b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl
@@ -23,9 +23,9 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-// https://w3c.github.io/deviceorientation/spec-source-orientation.html#deviceorientation
+// https://www.w3.org/TR/2016/CR-orientation-event-20160818/#deviceorientation
-// TODO(foolip): DeviceOrientationEvent should have a constructor.
+[Constructor(DOMString type, optional DeviceOrientationEventInit eventInitDict)]
interface DeviceOrientationEvent : Event {
readonly attribute double? alpha;
readonly attribute double? beta;

Powered by Google App Engine
This is Rietveld 408576698