Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2720943002: Implement DeviceMotionEvent constructor. (Closed)

Created:
3 years, 9 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, blink-reviews, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement DeviceMotionEvent constructor. This patch adds the DeviceMotionEvent constructor as defined in the spec: https://w3c.github.io/deviceorientation/spec-source-orientation.html#devicemotion DeviceAccelerationInit, DeviceMotionEventInit and DeviceRotationRateInit IDL dictionaries are added as dependencies. BUG=651767 Review-Url: https://codereview.chromium.org/2720943002 Cr-Commit-Position: refs/heads/master@{#454893} Committed: https://chromium.googlesource.com/chromium/src/+/3f08a50143c87ad0d41c03a0370884eccb788b39

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reference Candidate Recommendation. #

Messages

Total messages: 22 (15 generated)
Reilly Grant (use Gerrit)
timvolodine@, please review device_orientation changes. esprehn@, please review modules_idl_files.gni.
3 years, 9 months ago (2017-02-28 19:40:03 UTC) #8
timvolodine
and here lgtm https://codereview.chromium.org/2720943002/diff/1/third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.idl File third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.idl (right): https://codereview.chromium.org/2720943002/diff/1/third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.idl#newcode26 third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.idl:26: // https://w3c.github.io/deviceorientation/spec-source-orientation.html#devicemotion https://www.w3.org/TR/2016/CR-orientation-event-20160818/
3 years, 9 months ago (2017-03-02 23:31:23 UTC) #9
Reilly Grant (use Gerrit)
Reference Candidate Recommendation.
3 years, 9 months ago (2017-03-03 01:46:31 UTC) #10
Reilly Grant (use Gerrit)
https://codereview.chromium.org/2720943002/diff/1/third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.idl File third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.idl (right): https://codereview.chromium.org/2720943002/diff/1/third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.idl#newcode26 third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.idl:26: // https://w3c.github.io/deviceorientation/spec-source-orientation.html#devicemotion On 2017/03/02 23:31:23, timvolodine wrote: > https://www.w3.org/TR/2016/CR-orientation-event-20160818/ ...
3 years, 9 months ago (2017-03-03 01:46:36 UTC) #11
haraken
Implementation-wise LGTM.
3 years, 9 months ago (2017-03-03 01:53:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720943002/20001
3 years, 9 months ago (2017-03-06 15:57:52 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 18:27:39 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3f08a50143c87ad0d41c03a03708...

Powered by Google App Engine
This is Rietveld 408576698