third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.cpp - Issue 2720003003: Implement DeviceOrientationEvent constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.cpp

Issue 2720003003: Implement DeviceOrientationEvent constructor. (Closed)

Patch Set: Reference Candidate Recommendation. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.h ('k') | third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.cpp

diff --git a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.cpp b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.cpp

index 9ae63337d513be898f64c813a254f2cc46c21c54..f5edc72757459bd3ae6760c18e54359020e61228 100644

--- a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.cpp

+++ b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.cpp

@@ -26,6 +26,7 @@

#include "modules/device_orientation/DeviceOrientationEvent.h"

#include "modules/device_orientation/DeviceOrientationData.h"

+#include "modules/device_orientation/DeviceOrientationEventInit.h"

namespace blink {

@@ -36,6 +37,12 @@ DeviceOrientationEvent::DeviceOrientationEvent()

DeviceOrientationEvent::DeviceOrientationEvent(

const AtomicString& eventType,

+ const DeviceOrientationEventInit& initializer)

+ : Event(eventType, initializer),

+ m_orientation(DeviceOrientationData::create(initializer)) {}

+DeviceOrientationEvent::DeviceOrientationEvent(

+ const AtomicString& eventType,

DeviceOrientationData* orientation)

: Event(eventType, false, false), // Can't bubble, not cancelable

m_orientation(orientation) {}