Mash Session: Do not launch a browser service at startup

Mash Session: Do not launch a browser service at startup

After [1], mash_session is no longer needed by "chrome --mash" and the
relevant services are explicitely launched by MashRunner. In particular
the browser service was added back in [2]. Hence making mash_session
launch a browser service a startup is not so important for developers.
Hence this CL modifies mash_session to remove that behavior.

[1] https://codereview.chromium.org/2646033002
[2] https://codereview.chromium.org/2686003002

BUG=None

[fwang, 2017-02-27 16:44:07]

The CQ bit was checked by fwang@igalia.com to run a CQ dry run

[fwang, 2017-02-27 16:44:18]

Description was changed from

==========
Mash Session: Do not launch a browser service at startup

After [1], mash_session is no longer needed by "chrome --mash" and the
relevant services are explicitely launched by MashRunner. In particular
the browser service was added back in [2]. Hence making mash_session
launch a browser service a startup is not so important for developers.
Hence this CL modifies mash_session to remove that behavior.

[1] https://codereview.chromium.org/2646033002
[2] https://codereview.chromium.org/2686003002

BUG=None
==========

to

==========
Mash Session: Do not launch a browser service at startup

After [1], mash_session is no longer needed by "chrome --mash" and the
relevant services are explicitely launched by MashRunner. In particular
the browser service was added back in [2]. Hence making mash_session
launch a browser service a startup is not so important for developers.
Hence this CL modifies mash_session to remove that behavior.

[1] https://codereview.chromium.org/2646033002
[2] https://codereview.chromium.org/2686003002

BUG=None
==========

[commit-bot: I haz the power, 2017-02-27 16:44:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 17:11:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 17:11:55]

Dry run: This issue passed the CQ dry run.

[fwang, 2017-02-27 17:16:43]

fwang@igalia.com changed reviewers:
+ sky@chromium.org

[fwang, 2017-02-27 17:16:44]

PTAL

IIUC, mash_session is now only launched from
chrome/test/base/mash_browser_tests_main.cc or if one explicitly asks the
service to start (e.g. with the mash program). That comment saying that we don't
want mash_session to launch a browser service in the long term was added by msw
in https://codereview.chromium.org/2235493002. My understanding is that at least
it is no longer relevant for "chrome --mash".

[sky, 2017-02-28 04:17:58]

https://codereview.chromium.org/2719983002/diff/1/chrome/test/base/mash_brows...
File chrome/test/base/mash_browser_tests_main.cc (right):

https://codereview.chromium.org/2719983002/diff/1/chrome/test/base/mash_brows...
chrome/test/base/mash_browser_tests_main.cc:49:
connector->Connect(content::mojom::kPackagedServicesServiceName);
Why are you changing this?

https://codereview.chromium.org/2719983002/diff/1/mash/session/session.cc
File mash/session/session.cc (left):

https://codereview.chromium.org/2719983002/diff/1/mash/session/session.cc#old...
mash/session/session.cc:26: // Launch a chrome window for dev convience; don't
do this in the long term.
I think it's still convenient to do this. In particular it can be useful to
build chrome once, and then build mash:all. Is there a reason you don't want to
do this? If you don't want chrome launched you can just remove the executable.

[fwang, 2017-02-28 07:06:51]

https://codereview.chromium.org/2719983002/diff/1/chrome/test/base/mash_brows...
File chrome/test/base/mash_browser_tests_main.cc (right):

https://codereview.chromium.org/2719983002/diff/1/chrome/test/base/mash_brows...
chrome/test/base/mash_browser_tests_main.cc:49:
connector->Connect(content::mojom::kPackagedServicesServiceName);
On 2017/02/28 04:17:57, sky wrote:
> Why are you changing this?

This is only to preserve the behavior that browser service is launched.

https://codereview.chromium.org/2719983002/diff/1/mash/session/session.cc
File mash/session/session.cc (left):

https://codereview.chromium.org/2719983002/diff/1/mash/session/session.cc#old...
mash/session/session.cc:26: // Launch a chrome window for dev convience; don't
do this in the long term.
On 2017/02/28 04:17:57, sky wrote:
> I think it's still convenient to do this. In particular it can be useful to
> build chrome once, and then build mash:all. Is there a reason you don't want
to
> do this? If you don't want chrome launched you can just remove the executable.

No particular reason, I just saw this message again while reading the code and I
wondered whether it was still useful. I see your point for people working on
mash:all, so let's ignore this CL for now.