Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Issue 2686003002: mash: Exit main process if content_browser service crashes (Closed)

Created:
3 years, 10 months ago by James Cook
Modified:
3 years, 10 months ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Exit main process if content_browser service crashes For the ash/browser and window-server/browser connections both sides cache information about the other side. For now, rather than trying to make the services restartable we just bring down the main chrome --mash root process. The Chrome OS session_manager will then restart everything. Also explicitly start content_browser on startup, like mash_session used to do. It provides interfaces needed by ash (prefs, login state) that we're going to need for a while. BUG=678683 TEST=navigate to about:inducebrowsercrashforrealz, root process exits Review-Url: https://codereview.chromium.org/2686003002 Cr-Commit-Position: refs/heads/master@{#450506} Committed: https://chromium.googlesource.com/chromium/src/+/896d1d57393c5a0d787210a3e24007e973fb2fe5

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/app/mash/chrome_mash_manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/mash/mash_runner.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
James Cook
Ken, please take a look. https://codereview.chromium.org/2686003002/diff/1/chrome/app/mash/chrome_mash_manifest.json File chrome/app/mash/chrome_mash_manifest.json (right): https://codereview.chromium.org/2686003002/diff/1/chrome/app/mash/chrome_mash_manifest.json#newcode21 chrome/app/mash/chrome_mash_manifest.json:21: "content_browser": [ "app" ], ...
3 years, 10 months ago (2017-02-08 22:07:54 UTC) #2
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/2686003002/diff/1/chrome/app/mash/chrome_mash_manifest.json File chrome/app/mash/chrome_mash_manifest.json (right): https://codereview.chromium.org/2686003002/diff/1/chrome/app/mash/chrome_mash_manifest.json#newcode21 chrome/app/mash/chrome_mash_manifest.json:21: "content_browser": [ "app" ], On 2017/02/08 at 22:07:54, ...
3 years, 10 months ago (2017-02-08 23:04:08 UTC) #7
James Cook
I think we're good to land this now. It doesn't seem to cause issues with ...
3 years, 10 months ago (2017-02-14 22:17:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686003002/40001
3 years, 10 months ago (2017-02-14 22:18:22 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 23:12:19 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/896d1d57393c5a0d787210a3e240...

Powered by Google App Engine
This is Rietveld 408576698