mash: Disable ash_sysui; begin removal.

mash: Disable ash_sysui; begin removal.

Do not start mojo:ash_sysui in "chrome --mash" sessions.
(still runs ash (wm), quick_launch, exe:chrome, etc.)

Remove ShelfLayout and UserWindow* mojoms and impls.
(these were for mojo:ash_sysui<->mojo:ash communication)
Move wallpaper.mojom to ash/public/interfaces.

Nix RootWindowController::Get[Shelf|Status]LayoutManager.
Other misc related cleanup.

BUG=616857
TEST=chrome --mash doesn't show a shelf, status or background (for now).
R=sky@chromium.org
TBR=tsepez@chromium.org

Committed: https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3
Cr-Commit-Position: refs/heads/master@{#410921}

[msw, 2016-08-09 23:24:37]

Description was changed from

==========
mash: Disable ash_sysui; begin removal.

BUG=616857
TEST=chrome --mash doesn't show a shelf, status or background (for now).
R=sky@chromium.org
==========

to

==========
mash: Disable ash_sysui; begin removal.

Do not start mojo:ash_sysui in "chrome --mash" sessions.
(still runs ash (wm), quick_launch, can run exe:chrome, etc.)

Remove ShelfLayout and UserWindow* mojoms and impls.
(these were for mojo:ash_sysui<->mojo:ash communication)
Move wallpaper.mojom to ash/public/interfaces.

Nix RootWindowController::Get[Shelf|Status]LayoutManager.
Other misc related cleanup.

BUG=616857
TEST=chrome --mash doesn't show a shelf, status or background (for now).
R=sky@chromium.org
==========

[msw, 2016-08-09 23:31:23]

Hey Scott, please take a look; thanks. FYI, James.

https://codereview.chromium.org/2235493002/diff/20001/chrome/app/mojo/chrome_...
File chrome/app/mojo/chrome_manifest.json (right):

https://codereview.chromium.org/2235493002/diff/20001/chrome/app/mojo/chrome_...
chrome/app/mojo/chrome_manifest.json:8: "mojo:ash": {
This is just a placeholder for now; these interfaces aren't yet supported in
mojo:ash, but soon should be. Let me know if you'd rather remove them for now
and add them back in the next cl.

https://codereview.chromium.org/2235493002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc (right):

https://codereview.chromium.org/2235493002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc:206:
connector->ConnectToInterface("mojo:ash", &wallpaper_controller);
Ditto, this connection is just a placeholder for now.

https://codereview.chromium.org/2235493002/diff/20001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc (right):

https://codereview.chromium.org/2235493002/diff/20001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc:75:
connector->ConnectToInterface("mojo:ash", &shelf_controller_);
Ditto, this connection is just a placeholder for now.

[msw, 2016-08-09 23:31:28]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 23:33:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 23:39:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 23:39:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-08-09 23:55:19]

LGTM

[msw, 2016-08-10 00:23:36]

Description was changed from

==========
mash: Disable ash_sysui; begin removal.

Do not start mojo:ash_sysui in "chrome --mash" sessions.
(still runs ash (wm), quick_launch, can run exe:chrome, etc.)

Remove ShelfLayout and UserWindow* mojoms and impls.
(these were for mojo:ash_sysui<->mojo:ash communication)
Move wallpaper.mojom to ash/public/interfaces.

Nix RootWindowController::Get[Shelf|Status]LayoutManager.
Other misc related cleanup.

BUG=616857
TEST=chrome --mash doesn't show a shelf, status or background (for now).
R=sky@chromium.org
==========

to

==========
mash: Disable ash_sysui; begin removal.

Do not start mojo:ash_sysui in "chrome --mash" sessions.
(still runs ash (wm), quick_launch, exe:chrome, etc.)

Remove ShelfLayout and UserWindow* mojoms and impls.
(these were for mojo:ash_sysui<->mojo:ash communication)
Move wallpaper.mojom to ash/public/interfaces.

Nix RootWindowController::Get[Shelf|Status]LayoutManager.
Other misc related cleanup.

BUG=616857
TEST=chrome --mash doesn't show a shelf, status or background (for now).
R=sky@chromium.org
==========

[msw, 2016-08-10 00:23:45]

The CQ bit was checked by msw@chromium.org

[msw, 2016-08-10 00:23:45]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2235493002/#ps60001
(title: "Connect to chrome on mash session launch; add missing gn dep.")

[commit-bot: I haz the power, 2016-08-10 00:24:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 00:33:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 00:33:17]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[msw, 2016-08-10 01:26:53]

Description was changed from

==========
mash: Disable ash_sysui; begin removal.

Do not start mojo:ash_sysui in "chrome --mash" sessions.
(still runs ash (wm), quick_launch, exe:chrome, etc.)

Remove ShelfLayout and UserWindow* mojoms and impls.
(these were for mojo:ash_sysui<->mojo:ash communication)
Move wallpaper.mojom to ash/public/interfaces.

Nix RootWindowController::Get[Shelf|Status]LayoutManager.
Other misc related cleanup.

BUG=616857
TEST=chrome --mash doesn't show a shelf, status or background (for now).
R=sky@chromium.org
==========

to

==========
mash: Disable ash_sysui; begin removal.

Do not start mojo:ash_sysui in "chrome --mash" sessions.
(still runs ash (wm), quick_launch, exe:chrome, etc.)

Remove ShelfLayout and UserWindow* mojoms and impls.
(these were for mojo:ash_sysui<->mojo:ash communication)
Move wallpaper.mojom to ash/public/interfaces.

Nix RootWindowController::Get[Shelf|Status]LayoutManager.
Other misc related cleanup.

BUG=616857
TEST=chrome --mash doesn't show a shelf, status or background (for now).
R=sky@chromium.org
TBR=tsepez@chromium.org
==========

[msw, 2016-08-10 01:26:54]

msw@chromium.org changed reviewers:
+ tsepez@chromium.org

[msw, 2016-08-10 01:27:53]

+TBR tsepez for ash/public/interfaces

[msw, 2016-08-10 01:28:23]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-08-10 01:29:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 02:06:30]

Description was changed from

==========
mash: Disable ash_sysui; begin removal.

Do not start mojo:ash_sysui in "chrome --mash" sessions.
(still runs ash (wm), quick_launch, exe:chrome, etc.)

Remove ShelfLayout and UserWindow* mojoms and impls.
(these were for mojo:ash_sysui<->mojo:ash communication)
Move wallpaper.mojom to ash/public/interfaces.

Nix RootWindowController::Get[Shelf|Status]LayoutManager.
Other misc related cleanup.

BUG=616857
TEST=chrome --mash doesn't show a shelf, status or background (for now).
R=sky@chromium.org
TBR=tsepez@chromium.org
==========

to

==========
mash: Disable ash_sysui; begin removal.

Do not start mojo:ash_sysui in "chrome --mash" sessions.
(still runs ash (wm), quick_launch, exe:chrome, etc.)

Remove ShelfLayout and UserWindow* mojoms and impls.
(these were for mojo:ash_sysui<->mojo:ash communication)
Move wallpaper.mojom to ash/public/interfaces.

Nix RootWindowController::Get[Shelf|Status]LayoutManager.
Other misc related cleanup.

BUG=616857
TEST=chrome --mash doesn't show a shelf, status or background (for now).
R=sky@chromium.org
TBR=tsepez@chromium.org
==========

[commit-bot: I haz the power, 2016-08-10 02:06:41]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-10 02:08:17]

Description was changed from

==========
mash: Disable ash_sysui; begin removal.

Do not start mojo:ash_sysui in "chrome --mash" sessions.
(still runs ash (wm), quick_launch, exe:chrome, etc.)

Remove ShelfLayout and UserWindow* mojoms and impls.
(these were for mojo:ash_sysui<->mojo:ash communication)
Move wallpaper.mojom to ash/public/interfaces.

Nix RootWindowController::Get[Shelf|Status]LayoutManager.
Other misc related cleanup.

BUG=616857
TEST=chrome --mash doesn't show a shelf, status or background (for now).
R=sky@chromium.org
TBR=tsepez@chromium.org
==========

to

==========
mash: Disable ash_sysui; begin removal.

Do not start mojo:ash_sysui in "chrome --mash" sessions.
(still runs ash (wm), quick_launch, exe:chrome, etc.)

Remove ShelfLayout and UserWindow* mojoms and impls.
(these were for mojo:ash_sysui<->mojo:ash communication)
Move wallpaper.mojom to ash/public/interfaces.

Nix RootWindowController::Get[Shelf|Status]LayoutManager.
Other misc related cleanup.

BUG=616857
TEST=chrome --mash doesn't show a shelf, status or background (for now).
R=sky@chromium.org
TBR=tsepez@chromium.org

Committed: https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3
Cr-Commit-Position: refs/heads/master@{#410921}
==========

[commit-bot: I haz the power, 2016-08-10 02:08:18]

Patchset 4 (id:??) landed as
https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3
Cr-Commit-Position: refs/heads/master@{#410921}