Mash Session: Do not launch a browser service at startup

mash/session/session.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mash/session/session.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "content/public/common/service_names.mojom.h"
 #include "mash/common/config.h"
 #include "mash/quick_launch/public/interfaces/constants.mojom.h"
 #include "services/service_manager/public/cpp/connector.h"
 #include "services/service_manager/public/cpp/service_context.h"
 
 namespace mash {
 namespace session {
 
 Session::Session() {}
 Session::~Session() {}
 
 void Session::OnStart() {
   StartWindowManager();
   StartQuickLaunch();
-
-  // Launch a chrome window for dev convience; don't do this in the long term.

[sky, 2017/02/28 04:17:57]

I think it's still convenient to do this. In particular it can be useful to
build chrome once, and then build mash:all. Is there a reason you don't want to
do this? If you don't want chrome launched you can just remove the executable.

[fwang, 2017/02/28 07:06:51]

No particular reason, I just saw this message again while reading the code and I
wondered whether it was still useful. I see your point for people working on
mash:all, so let's ignore this CL for now.

-  context()->connector()->Connect(content::mojom::kPackagedServicesServiceName);
 }
 
 void Session::StartWindowManager() {
   // TODO(beng): monitor this service for death & bring down the whole system
   // if necessary.
   context()->connector()->Connect(common::GetWindowManagerServiceName());
 }
 
 void Session::StartQuickLaunch() {
   // TODO(beng): monitor this service for death & bring down the whole system
   // if necessary.
   context()->connector()->Connect(quick_launch::mojom::kServiceName);
 }
 
 }  // namespace session
 }  // namespace main